From 92f5150a01631a49ccc370188cc04309ea5263c1 Mon Sep 17 00:00:00 2001 From: Kyle De'Vir Date: Wed, 8 Jun 2016 00:39:30 +1000 Subject: [PATCH] Revert "Revert "Corrected errors in Perspective function"" This reverts commit 743d03451da3c55802d2125bf9c0de5148f4ae8c. --- HandmadeMath.h | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/HandmadeMath.h b/HandmadeMath.h index 33fddab..3311ae5 100644 --- a/HandmadeMath.h +++ b/HandmadeMath.h @@ -773,11 +773,13 @@ HMM_Perspective(float FOV, float AspectRatio, float Near, float Far) { hmm_mat4 Result = HMM_Mat4d(1.0f); - Result.Elements[0][0] = 1.0f / (AspectRatio * tanf(FOV / 2.0f)); - Result.Elements[1][1] = 1.0f / tanf(FOV / 2.0f); + float TanThetaOver2 = tanf(FOV * (HMM_PI32 / 360.0f)); + + Result.Elements[0][0] = 1.0f / TanThetaOver2; + Result.Elements[1][1] = AspectRatio / TanThetaOver2; Result.Elements[2][3] = -1.0f; - Result.Elements[2][2] = -(Far + Near) / (Far - Near); - Result.Elements[3][2] = -(2.0f * Far * Near) / (Far - Near); + Result.Elements[2][2] = (Near + Far) / (Near - Far); + Result.Elements[3][2] = (2.0f * Near * Far) / (Near - Far); Result.Elements[3][3] = 0.0f; return (Result);