From 05384efec53256d8917a80d1117d8f822a8a2f55 Mon Sep 17 00:00:00 2001 From: Juan Carlos Date: Tue, 30 Jun 2020 14:09:13 -0300 Subject: [PATCH] Clean out sharedtables (#14858) Co-authored-by: Andreas Rumpf --- changelog.md | 1 + lib/pure/collections/sharedtables.nim | 10 ---------- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/changelog.md b/changelog.md index 35c701a8ae..f32d6f19f6 100644 --- a/changelog.md +++ b/changelog.md @@ -185,6 +185,7 @@ proc mydiv(a, b): int {.raises: [].} = - Added the `thiscall` calling convention as specified by Microsoft, mostly for hooking purpose - Deprecated `{.unroll.}` pragma, was ignored by the compiler anyways, was a nop. +- Remove `sharedtables.initSharedTable`, was deprecated and produces undefined behavior. - Removed `asyncdispatch.newAsyncNativeSocket`, was deprecated since `0.18`. - Remove `dom.releaseEvents` and `dom.captureEvents`, was deprecated. diff --git a/lib/pure/collections/sharedtables.nim b/lib/pure/collections/sharedtables.nim index 23b653c82c..abef895076 100644 --- a/lib/pure/collections/sharedtables.nim +++ b/lib/pure/collections/sharedtables.nim @@ -225,13 +225,3 @@ proc init*[A, B](t: var SharedTable[A, B], initialSize = 64) = proc deinitSharedTable*[A, B](t: var SharedTable[A, B]) = deallocShared(t.data) deinitLock t.lock - -proc initSharedTable*[A, B](initialSize = 64): SharedTable[A, B] {.deprecated: - "use 'init' instead".} = - ## This is not posix compliant, may introduce undefined behavior. - assert isPowerOfTwo(initialSize) - result.counter = 0 - result.dataLen = initialSize - result.data = cast[KeyValuePairSeq[A, B]](allocShared0( - sizeof(KeyValuePair[A, B]) * initialSize)) - initLock result.lock