From 0b319fee3de90759987beba289df3c48ab6d3f1a Mon Sep 17 00:00:00 2001
From: Bung <crc32@qq.com>
Date: Fri, 23 Dec 2022 19:20:25 +0800
Subject: [PATCH] =?UTF-8?q?fix=20#20997=20calling=20system.card[T](x:=20se?=
 =?UTF-8?q?t[T])=20with=20T=20of=20int8=20or=20uint8=20=E2=80=A6=20(#21010?=
 =?UTF-8?q?)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* fix #20997 calling system.card[T](x: set[T]) with T of int8 or uint8 uses mismatched C array sizes
* fullfil set variant
---
 compiler/ccgexprs.nim |  2 +-
 lib/system/sets.nim   |  8 +++++---
 tests/sets/t20997.nim | 18 ++++++++++++++++++
 3 files changed, 24 insertions(+), 4 deletions(-)
 create mode 100644 tests/sets/t20997.nim

diff --git a/compiler/ccgexprs.nim b/compiler/ccgexprs.nim
index 2a4335144a..d7ef024b15 100644
--- a/compiler/ccgexprs.nim
+++ b/compiler/ccgexprs.nim
@@ -2126,7 +2126,7 @@ proc genSetOp(p: BProc, e: PNode, d: var TLoc, op: TMagic) =
     of mCard:
       var a: TLoc
       initLocExpr(p, e[1], a)
-      putIntoDest(p, d, e, ropecg(p.module, "#cardSet($1, $2)", [rdCharLoc(a), size]))
+      putIntoDest(p, d, e, ropecg(p.module, "#cardSet($1, $2)", [addrLoc(p.config, a), size]))
     of mLtSet, mLeSet:
       getTemp(p, getSysType(p.module.g.graph, unknownLineInfo, tyInt), i) # our counter
       initLocExpr(p, e[1], a)
diff --git a/lib/system/sets.nim b/lib/system/sets.nim
index 103c8d343e..e230985e0b 100644
--- a/lib/system/sets.nim
+++ b/lib/system/sets.nim
@@ -10,10 +10,9 @@
 # set handling
 
 type
-  NimSet = array[0..4*2048-1, uint8]
+  NimSet = array[0..8192-1, uint8]
 
-
-proc cardSet(s: NimSet, len: int): int {.compilerproc, inline.} =
+proc cardSetImpl(s: openArray[uint8], len: int): int {.inline.} =
   var i = 0
   result = 0
   when defined(x86) or defined(amd64):
@@ -24,3 +23,6 @@ proc cardSet(s: NimSet, len: int): int {.compilerproc, inline.} =
   while i < len:
     inc(result, countBits32(uint32(s[i])))
     inc(i, 1)
+
+proc cardSet(s: NimSet, len: int): int {.compilerproc, inline.} =
+  result = cardSetImpl(s, len)
diff --git a/tests/sets/t20997.nim b/tests/sets/t20997.nim
new file mode 100644
index 0000000000..b320eee1ad
--- /dev/null
+++ b/tests/sets/t20997.nim
@@ -0,0 +1,18 @@
+discard """
+  joinable: false
+"""
+
+{.passC: "-flto".}
+{.passL: "-flto".}
+
+template f(n: int) = discard card(default(set[range[0 .. (1 shl n) - 1]]))
+f( 7)
+f( 8)
+f( 9)
+f(10)
+f(11)
+f(12)
+f(13)
+f(14)
+f(15)
+f(16)