From 171721bf49bd154a671c3213cf9aa92a5774e6be Mon Sep 17 00:00:00 2001 From: citycide Date: Sat, 27 Oct 2018 11:52:57 -0500 Subject: [PATCH] docs: clarify `asyncCheck` vs `waitFor` (cherry picked from commit 4362ba7293e7527ff57f69bf2a0e95fdfd84985e) --- lib/pure/asyncdispatch.nim | 4 +++- lib/pure/asyncfutures.nim | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/pure/asyncdispatch.nim b/lib/pure/asyncdispatch.nim index edd509f506..5ef791cfe9 100644 --- a/lib/pure/asyncdispatch.nim +++ b/lib/pure/asyncdispatch.nim @@ -145,7 +145,9 @@ export asyncfutures, asyncstreams ## ## Futures should **never** be discarded. This is because they may contain ## errors. If you do not care for the result of a Future then you should -## use the ``asyncCheck`` procedure instead of the ``discard`` keyword. +## use the ``asyncCheck`` procedure instead of the ``discard`` keyword. Note +## however that this does not wait for completion, and you should use +## ``waitFor`` for that purpose. ## ## Examples ## -------- diff --git a/lib/pure/asyncfutures.nim b/lib/pure/asyncfutures.nim index df0e7c17e8..965e700551 100644 --- a/lib/pure/asyncfutures.nim +++ b/lib/pure/asyncfutures.nim @@ -339,7 +339,8 @@ proc asyncCheck*[T](future: Future[T]) = ## Sets a callback on ``future`` which raises an exception if the future ## finished with an error. ## - ## This should be used instead of ``discard`` to discard void futures. + ## This should be used instead of ``discard`` to discard void futures, + ## or use ``waitFor`` if you need to wait for the future's completion. assert(not future.isNil, "Future is nil") future.callback = proc () =