From 19ccce2617116270c5a83324f5f442fa7d239ee8 Mon Sep 17 00:00:00 2001 From: Leorize Date: Wed, 3 Jun 2020 13:42:12 -0500 Subject: [PATCH] Revert "net: don't clear all errors on close" You're supposed to clear the error queue before any I/O operations. Per SSL_get_error(3) man page. This reverts commit ee3ed37300743addb1344e39bc46d3cd2b89a718. --- lib/pure/net.nim | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/pure/net.nim b/lib/pure/net.nim index d807a51123..f7aacfb0c3 100644 --- a/lib/pure/net.nim +++ b/lib/pure/net.nim @@ -1006,6 +1006,7 @@ proc close*(socket: Socket) = try: when defineSsl: if socket.isSsl and socket.sslHandle != nil: + ErrClearError() # Don't call SSL_shutdown if the connection has not been fully # established, see: # https://github.com/openssl/openssl/issues/710#issuecomment-253897666