Correctly mangle this in the JS backend (#8853)

As shown in pragmagic/karax#67 using `this` as parameter name made the
codegen output wrong code (and the user didn't notice the errors in the
browser console).
This commit is contained in:
LemonBoy
2018-09-03 17:51:30 +02:00
committed by Andreas Rumpf
parent 0694c9080f
commit 1a60ffcf1d
3 changed files with 27 additions and 3 deletions

View File

@@ -267,8 +267,8 @@ block:
type TestObject = object
a: int
onWhatever: proc(e: int): int
proc handleWhatever(that: TestObject, e: int): int =
e + that.a
proc handleWhatever(this: TestObject, e: int): int =
e + this.a
proc test(): bool =
let obj = TestObject(a: 9, onWhatever: bindMethod(handleWhatever))
obj.onWhatever(1) == 10

23
tests/js/tthismangle.nim Normal file
View File

@@ -0,0 +1,23 @@
proc moo1(this: int) =
doAssert this == 42
proc moo2(x: int) =
var this = x
doAssert this == 42
proc moo3() =
for this in [1,1,1]:
doAssert this == 1
proc moo4() =
type
X = object
this: int
var q = X(this: 42)
doAssert q.this == 42
moo1(42)
moo2(42)
moo3()
moo4()