From 3698f197f10b775cbe0824936637b7e7d294eb19 Mon Sep 17 00:00:00 2001 From: Danil Yarantsev Date: Mon, 1 Jun 2020 18:07:01 +0300 Subject: [PATCH] Change severity of template instantiation message [backport] (#14526) * Change severity of template instatiation msg * Add a test * Trailing newline argh --- compiler/msgs.nim | 2 +- nimsuggest/tests/ttempl_inst.nim | 13 +++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) create mode 100644 nimsuggest/tests/ttempl_inst.nim diff --git a/compiler/msgs.nim b/compiler/msgs.nim index c4658abcfe..eca3b0276a 100644 --- a/compiler/msgs.nim +++ b/compiler/msgs.nim @@ -421,7 +421,7 @@ proc writeContext(conf: ConfigRef; lastinfo: TLineInfo) = if context.info != lastinfo and context.info != info: if conf.structuredErrorHook != nil: conf.structuredErrorHook(conf, context.info, instantiationFrom, - Severity.Error) + Severity.Hint) else: let message = if context.detail == "": instantiationFrom diff --git a/nimsuggest/tests/ttempl_inst.nim b/nimsuggest/tests/ttempl_inst.nim new file mode 100644 index 0000000000..ed04a67ce1 --- /dev/null +++ b/nimsuggest/tests/ttempl_inst.nim @@ -0,0 +1,13 @@ +template foo() = + {.warning: "foo".} + +foo() + +#[!]# +discard """ +$nimsuggest --tester $file +>chk $1 +chk;;skUnknown;;;;Hint;;???;;0;;-1;;"ttempl_inst [Processing]";;0 +chk;;skUnknown;;;;Hint;;$file;;4;;3;;"template/generic instantiation from here";;0 +chk;;skUnknown;;;;Warning;;$file;;2;;11;;"foo [User]";;0 +"""