From 3948b40bcd79a3883529608bf4bd156c2e9de5f8 Mon Sep 17 00:00:00 2001 From: ee7 <45465154+ee7@users.noreply.github.com> Date: Mon, 9 Nov 2020 13:08:17 +0100 Subject: [PATCH] CI(actions): Replace deprecated `add-path` commands (#15892) This commit resolves the following warning in the CI logs: > Error: The `add-path` command is deprecated and will be disabled soon. > Please upgrade to using Environment Files. For more information see: > https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ The deprecation is due to an injection vulnerability (CVE-2020-15228). See: - https://bugs.chromium.org/p/project-zero/issues/detail?id=2070 - https://github.com/nim-lang/Nim/runs/1373146963#step:8:1 --- .github/workflows/ci.yml.disabled | 4 ++-- .github/workflows/ci_docs.yml | 4 ++-- .github/workflows/ci_packages.yml | 4 ++-- .github/workflows/ci_ssl.yml | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci.yml.disabled b/.github/workflows/ci.yml.disabled index 446560663d..1835764563 100644 --- a/.github/workflows/ci.yml.disabled +++ b/.github/workflows/ci.yml.disabled @@ -85,11 +85,11 @@ jobs: curl -L https://nim-lang.org/download/dlls.zip -o dist/dlls.zip 7z x dist/mingw64.7z -odist 7z x dist/dlls.zip -obin - echo "::add-path::${{ github.workspace }}/dist/mingw64/bin" + echo "${{ github.workspace }}/dist/mingw64/bin" >> "${GITHUB_PATH}" - name: 'Add build binaries to PATH' shell: bash - run: echo "::add-path::${{ github.workspace }}/bin" + run: echo "${{ github.workspace }}/bin" >> "${GITHUB_PATH}" - name: 'Build csources' shell: bash diff --git a/.github/workflows/ci_docs.yml b/.github/workflows/ci_docs.yml index 718dcd7e3f..74ca804f32 100644 --- a/.github/workflows/ci_docs.yml +++ b/.github/workflows/ci_docs.yml @@ -64,11 +64,11 @@ jobs: curl -L https://nim-lang.org/download/dlls.zip -o dist/dlls.zip 7z x dist/mingw64.7z -odist 7z x dist/dlls.zip -obin - echo "::add-path::${{ github.workspace }}/dist/mingw64/bin" + echo "${{ github.workspace }}/dist/mingw64/bin" >> "${GITHUB_PATH}" - name: 'Add build binaries to PATH' shell: bash - run: echo "::add-path::${{ github.workspace }}/bin" + run: echo "${{ github.workspace }}/bin" >> "${GITHUB_PATH}" - name: 'Get current csources version' id: csources-version diff --git a/.github/workflows/ci_packages.yml b/.github/workflows/ci_packages.yml index 0d2f89aa68..59e918f589 100644 --- a/.github/workflows/ci_packages.yml +++ b/.github/workflows/ci_packages.yml @@ -48,11 +48,11 @@ jobs: curl -L https://nim-lang.org/download/dlls.zip -o dist/dlls.zip 7z x dist/mingw64.7z -odist 7z x dist/dlls.zip -obin - echo "::add-path::${{ github.workspace }}/dist/mingw64/bin" + echo "${{ github.workspace }}/dist/mingw64/bin" >> "${GITHUB_PATH}" - name: 'Add build binaries to PATH' shell: bash - run: echo "::add-path::${{ github.workspace }}/bin" + run: echo "${{ github.workspace }}/bin" >> "${GITHUB_PATH}" - name: 'Build csources' shell: bash diff --git a/.github/workflows/ci_ssl.yml b/.github/workflows/ci_ssl.yml index 6a024eca00..0ec7aeb3bb 100644 --- a/.github/workflows/ci_ssl.yml +++ b/.github/workflows/ci_ssl.yml @@ -49,11 +49,11 @@ jobs: curl -L https://nim-lang.org/download/dlls.zip -o dist/dlls.zip 7z x dist/mingw64.7z -odist 7z x dist/dlls.zip -obin - echo "::add-path::${{ github.workspace }}/dist/mingw64/bin" + echo "${{ github.workspace }}/dist/mingw64/bin" >> "${GITHUB_PATH}" - name: 'Add build binaries to PATH' shell: bash - run: echo "::add-path::${{ github.workspace }}/bin" + run: echo "${{ github.workspace }}/bin" >> "${GITHUB_PATH}" - name: 'Build 1-stage compiler from csources' shell: bash