diff --git a/compiler/ccgexprs.nim b/compiler/ccgexprs.nim index f6cf799bd1..1d9d0aca64 100644 --- a/compiler/ccgexprs.nim +++ b/compiler/ccgexprs.nim @@ -1193,8 +1193,6 @@ proc genDefault(p: BProc; n: PNode; d: var TLoc) = if d.k == locNone: getTemp(p, n.typ, d, needsInit=true) else: resetLoc(p, d) -proc trivialDestructor(s: PSym): bool {.inline.} = s.ast[bodyPos].len == 0 - proc rawGenNew(p: BProc, a: TLoc, sizeExpr: Rope) = var sizeExpr = sizeExpr let typ = a.t diff --git a/compiler/ccgtypes.nim b/compiler/ccgtypes.nim index de1f0e4974..a867c58c1a 100644 --- a/compiler/ccgtypes.nim +++ b/compiler/ccgtypes.nim @@ -1275,6 +1275,8 @@ proc genTypeInfo2Name(m: BModule; t: PType): Rope = it = it.sons[0] result = makeCString(res) +proc trivialDestructor(s: PSym): bool {.inline.} = s.ast[bodyPos].len == 0 + proc genObjectInfoV2(m: BModule, t, origType: PType, name: Rope; info: TLineInfo) = assert t.kind == tyObject if incompleteType(t): @@ -1282,7 +1284,7 @@ proc genObjectInfoV2(m: BModule, t, origType: PType, name: Rope; info: TLineInfo typeToString(t)) var d: Rope - if t.destructor != nil: + if t.destructor != nil and not trivialDestructor(t.destructor): # the prototype of a destructor is ``=destroy(x: var T)`` and that of a # finalizer is: ``proc (x: ref T) {.nimcall.}``. We need to check the calling # convention at least: diff --git a/compiler/injectdestructors.nim b/compiler/injectdestructors.nim index f1823bf64c..78ab2daefd 100644 --- a/compiler/injectdestructors.nim +++ b/compiler/injectdestructors.nim @@ -173,6 +173,9 @@ proc genOp(c: Con; t: PType; kind: TTypeAttachedOp; dest, ri: PNode): PNode = elif op.ast[genericParamsPos].kind != nkEmpty: globalError(c.graph.config, dest.info, "internal error: '" & AttachedOpToStr[kind] & "' operator is generic") + dbg: + if kind == attachedDestructor: + echo "destructor is ", op.id, " ", op.ast if sfError in op.flags: checkForErrorPragma(c, t, ri, AttachedOpToStr[kind]) let addrExp = newNodeIT(nkHiddenAddr, dest.info, makePtrType(c, dest.typ)) addrExp.add(dest) @@ -681,4 +684,4 @@ proc injectDestructorCalls*(g: ModuleGraph; owner: PSym; n: PNode): PNode = result.add body dbg: echo ">---------transformed-to--------->" - echo result + echo renderTree(result, {renderIds}) diff --git a/compiler/lambdalifting.nim b/compiler/lambdalifting.nim index 4a2d40ec7b..9f1d29ec6b 100644 --- a/compiler/lambdalifting.nim +++ b/compiler/lambdalifting.nim @@ -233,6 +233,10 @@ proc liftingHarmful(conf: ConfigRef; owner: PSym): bool {.inline.} = let isCompileTime = sfCompileTime in owner.flags or owner.kind == skMacro result = conf.cmd == cmdCompileToJS and not isCompileTime +proc createTypeBoundOpsLL(g: ModuleGraph; refType: PType; info: TLineInfo) = + createTypeBoundOps(g, nil, refType.lastSon, info) + createTypeBoundOps(g, nil, refType, info) + proc liftIterSym*(g: ModuleGraph; n: PNode; owner: PSym): PNode = # transforms (iter) to (let env = newClosure[iter](); (iter, env)) if liftingHarmful(g.config, owner): return n @@ -257,8 +261,8 @@ proc liftIterSym*(g: ModuleGraph; n: PNode; owner: PSym): PNode = result.add(v) # add 'new' statement: result.add newCall(getSysSym(g, n.info, "internalNew"), env) - if optOwnedRefs in g.config.globalOptions: - createTypeBoundOps(g, nil, env.typ, n.info) + if g.config.selectedGC in {gcHooks, gcDestructors}: + createTypeBoundOpsLL(g, env.typ, n.info) result.add makeClosure(g, iter, env, n.info) proc freshVarForClosureIter*(g: ModuleGraph; s, owner: PSym): PNode = @@ -586,7 +590,7 @@ proc rawClosureCreation(owner: PSym; let env2 = copyTree(env) env2.typ = unowned.typ result.add newAsgnStmt(unowned, env2, env.info) - createTypeBoundOps(d.graph, nil, unowned.typ, env.info) + createTypeBoundOpsLL(d.graph, unowned.typ, env.info) # add assignment statements for captured parameters: for i in 1..