mirror of
https://github.com/nim-lang/Nim.git
synced 2026-04-24 00:05:25 +00:00
resolve unambiguous enum symchoices from local scope, error on rest (#22606)
fixes #22598, properly fixes #21887 and fixes test case issue number When an enum field sym choice has to choose a type, check if its name is ambiguous in the local scope, then check if the first symbol found in the local scope is the first symbol in the sym choice. If so, choose that symbol. Otherwise, give an ambiguous identifier error. The dependence on the local scope implies this will always give ambiguity errors for unpicked enum symchoices from generics and templates and macros from other scopes. We can change `not isAmbiguous(...) and foundSym == first` to `not (isAmbiguous(...) and foundSym == first)` to make it so they never give ambiguity errors, and always pick the first symbol in the symchoice. I can do this if this is preferred, but no code from CI seems affected.
This commit is contained in:
26
tests/enum/tambiguousoverloads.nim
Normal file
26
tests/enum/tambiguousoverloads.nim
Normal file
@@ -0,0 +1,26 @@
|
||||
discard """
|
||||
cmd: "nim check --hints:off $file"
|
||||
"""
|
||||
|
||||
block: # bug #21887
|
||||
type
|
||||
EnumA = enum A = 300, B
|
||||
EnumB = enum A = 10
|
||||
EnumC = enum C
|
||||
|
||||
doAssert typeof(EnumC(A)) is EnumC #[tt.Error
|
||||
^ ambiguous identifier 'A' -- use one of the following:
|
||||
EnumA.A: EnumA
|
||||
EnumB.A: EnumB]#
|
||||
|
||||
block: # issue #22598
|
||||
type
|
||||
A = enum
|
||||
red
|
||||
B = enum
|
||||
red
|
||||
|
||||
let a = red #[tt.Error
|
||||
^ ambiguous identifier 'red' -- use one of the following:
|
||||
A.red: A
|
||||
B.red: B]#
|
||||
@@ -118,11 +118,3 @@ block: # test with macros/templates
|
||||
doAssert isOneMS(e2)
|
||||
doAssert isOneT(e1)
|
||||
doAssert isOneT(e2)
|
||||
|
||||
block: # bug #21908
|
||||
type
|
||||
EnumA = enum A = 300, B
|
||||
EnumB = enum A = 10
|
||||
EnumC = enum C
|
||||
|
||||
doAssert typeof(EnumC(A)) is EnumC
|
||||
|
||||
Reference in New Issue
Block a user