From 4ae143ca60302b0d7a899196c451d57997875c1b Mon Sep 17 00:00:00 2001 From: alaviss Date: Tue, 8 Oct 2019 06:11:18 +0000 Subject: [PATCH] nimsuggest: fix tcp socket leak (#12377) [backport] A new socket is created for each iteration and leak immediately thanks to the accept() call replacing the created socket with the client socket. This commit fixes that. (cherry picked from commit e9fa4c9b9c8e2926449399a69a02676936bb842c) --- nimsuggest/nimsuggest.nim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nimsuggest/nimsuggest.nim b/nimsuggest/nimsuggest.nim index af87c9e7fa..b61dfe797e 100644 --- a/nimsuggest/nimsuggest.nim +++ b/nimsuggest/nimsuggest.nim @@ -319,8 +319,8 @@ proc replTcp(x: ThreadParams) {.thread.} = server.bindAddr(x.port, x.address) server.listen() var inp = "".TaintedString + var stdoutSocket: Socket while true: - var stdoutSocket = newSocket() accept(server, stdoutSocket) stdoutSocket.readLine(inp)