diff --git a/compiler/ccgexprs.nim b/compiler/ccgexprs.nim index 7380aa9855..55a410f268 100644 --- a/compiler/ccgexprs.nim +++ b/compiler/ccgexprs.nim @@ -1982,30 +1982,25 @@ proc genRangeChck(p: BProc, n: PNode, d: var TLoc) = checkUnsignedConversions notin p.config.legacyFeatures): discard "no need to generate a check because it was disabled" else: + let raiser = + case skipTypes(n.typ, abstractVarRange).kind + of tyUInt..tyUInt64, tyChar: "raiseRangeErrorU" + of tyFloat..tyFloat128: "raiseRangeErrorF" + else: "raiseRangeErrorI" + discard cgsym(p.module, raiser) + # This seems to be bug-compatible with Nim version 1 but what we + # should really do here is to check if uint64Value < high(int) let n0t = n[0].typ - + let boundaryCast = + if n0t.skipTypes(abstractVarRange).kind in {tyUInt, tyUInt32, tyUInt64} or + (n0t.sym != nil and sfSystemModule in n0t.sym.owner.flags and n0t.sym.name.s == "csize"): + "(NI64)" + else: + "" # emit range check: - if n0t.kind in {tyUInt, tyUInt64}: - linefmt(p, cpsStmts, "if ($1 > ($6)($3)){ #raiseRangeErrorNoArgs(); $5}$n", - [rdCharLoc(a), genLiteral(p, n[1], dest), genLiteral(p, n[2], dest), - raiser, raiseInstr(p), getTypeDesc(p.module, n0t)]) - else: - let raiser = - case skipTypes(n.typ, abstractVarRange).kind - of tyUInt..tyUInt64, tyChar: "raiseRangeErrorU" - of tyFloat..tyFloat128: "raiseRangeErrorF" - else: "raiseRangeErrorI" - discard cgsym(p.module, raiser) - - let boundaryCast = - if n0t.skipTypes(abstractVarRange).kind in {tyUInt, tyUInt32, tyUInt64} or - (n0t.sym != nil and sfSystemModule in n0t.sym.owner.flags and n0t.sym.name.s == "csize"): - "(NI64)" - else: - "" - linefmt(p, cpsStmts, "if ($6($1) < $2 || $6($1) > $3){ $4($1, $2, $3); $5}$n", - [rdCharLoc(a), genLiteral(p, n[1], dest), genLiteral(p, n[2], dest), - raiser, raiseInstr(p), boundaryCast]) + linefmt(p, cpsStmts, "if ($6($1) < $2 || $6($1) > $3){ $4($1, $2, $3); $5}$n", + [rdCharLoc(a), genLiteral(p, n[1], dest), genLiteral(p, n[2], dest), + raiser, raiseInstr(p), boundaryCast]) putIntoDest(p, d, n, "(($1) ($2))" % [getTypeDesc(p.module, dest), rdCharLoc(a)], a.storage) @@ -2671,7 +2666,9 @@ proc expr(p: BProc, n: PNode, d: var TLoc) = expr(p, n[1][0], d) of nkObjDownConv: downConv(p, n, d) of nkObjUpConv: upConv(p, n, d) - of nkChckRangeF, nkChckRange64, nkChckRange: genRangeChck(p, n, d) + of nkChckRangeF: genRangeChck(p, n, d) + of nkChckRange64: genRangeChck(p, n, d) + of nkChckRange: genRangeChck(p, n, d) of nkStringToCString: convStrToCStr(p, n, d) of nkCStringToString: convCStrToStr(p, n, d) of nkLambdaKinds: diff --git a/lib/system/chcks.nim b/lib/system/chcks.nim index 6e7df18b74..117543fcda 100644 --- a/lib/system/chcks.nim +++ b/lib/system/chcks.nim @@ -38,9 +38,6 @@ proc raiseRangeErrorU(i, a, b: uint64) {.compilerproc, noinline.} = # todo: better error reporting sysFatal(RangeError, "value out of range") -proc raiseRangeErrorNoArgs() {.compilerproc, noinline.} = - sysFatal(RangeError, "value out of range") - proc raiseObjectConversionError() {.compilerproc, noinline.} = sysFatal(ObjectConversionError, "invalid object conversion") diff --git a/testament/important_packages.nim b/testament/important_packages.nim index b09bb1147f..5b2e79934d 100644 --- a/testament/important_packages.nim +++ b/testament/important_packages.nim @@ -9,7 +9,7 @@ pkg "argparse" pkg "arraymancer", true, "nim c tests/tests_cpu.nim" pkg "ast_pattern_matching", false, "nim c -r --oldgensym:on tests/test1.nim" pkg "asyncmysql", true -pkg "bigints", url = "https://github.com/Araq/nim-bigints" +pkg "bigints" pkg "binaryheap", false, "nim c -r binaryheap.nim" # pkg "blscurve", true # pending https://github.com/status-im/nim-blscurve/issues/39 pkg "bncurve", true diff --git a/tests/misc/tunsignedconv.nim b/tests/misc/tunsignedconv.nim index 8068162083..e255d9cf75 100644 --- a/tests/misc/tunsignedconv.nim +++ b/tests/misc/tunsignedconv.nim @@ -75,14 +75,3 @@ let rangeVar = 0'u64 ..< limit doAssert repr(rangeVar) == """[a = 0, b = 0] """ - -# bug #15210 - -let a3 = not 0'u64 -var success = false -try: - discard a3.int64 -except RangeError: - success = true - -doAssert success, "conversion should fail at runtime"