mirrors/Nim
1
0
Fork 0
mirror of https://github.com/nim-lang/Nim.git synced 2026-05-02 12:04:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

remove conflicting default call in tables.getOrDefault (#24265)

Browse Source 
fixes #23587

As explained in the issue, `getOrDefault` has a parameter named
`default` that can be a proc after generic instantiation. But the
parameter having a proc type [overrides all other
overloads](f73e03b132/compiler/semexprs.nim (L1203))
including the magic `system.default` overload and causes a compile error
if the proc doesn't match the normal use of `default`. To fix this, the
`result = default(B)` initializer call is removed because it's not
needed, `result` is always set in `getOrDefaultImpl` when a default
value is provided.

This is still a suspicious behavior of the compiler but `tables` working
has a higher priority.
This commit is contained in:
metagn
2024-10-09 19:20:43 +03:00
committed by GitHub
parent 95a7695810
commit 67ea754b7f
5 changed files with 38 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
testament/important_packages.nim
View File

@@ -149,7 +149,7 @@ pkg "polypbren"
pkg "presto"
pkg "prologue", "nimble tcompile"
# remove fork after https://github.com/PMunch/combparser/pull/7 is merged:
pkg "protobuf", "nimble install -y https://github.com/metagn/combparser@#HEAD; nim c -o:protobuff -r src/protobuf.nim"
pkg "protobuf", "nimble uninstall -i -y combparser; nimble install -y https://github.com/metagn/combparser@#HEAD; nimble install --depsOnly -y; nim c -o:protobuff -r src/protobuf.nim"
pkg "rbtree"
pkg "react", "nimble example"
pkg "regex", "nim c src/regex"