From 6f1a72069a6992850813cd99d4d3aec4e595c438 Mon Sep 17 00:00:00 2001 From: flywind <43030857+xflywind@users.noreply.github.com> Date: Mon, 23 Nov 2020 00:16:42 +0800 Subject: [PATCH] fix #9695 asyncmacro: tfuturevar fails when activated [backport: 1.0] (#16090) * fix asyncmacro * Apply suggestions from code review * Update lib/pure/asyncmacro.nim --- lib/pure/asyncmacro.nim | 3 ++- tests/async/tfuturevar.nim | 5 ----- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/lib/pure/asyncmacro.nim b/lib/pure/asyncmacro.nim index 579e9fede8..a705087361 100644 --- a/lib/pure/asyncmacro.nim +++ b/lib/pure/asyncmacro.nim @@ -118,7 +118,8 @@ proc getFutureVarIdents(params: NimNode): seq[NimNode] {.compileTime.} = for i in 1 ..< len(params): expectKind(params[i], nnkIdentDefs) if params[i][1].kind == nnkBracketExpr and - params[i][1][0].eqIdent("futurevar"): + params[i][1][0].eqIdent(FutureVar.astToStr): + ## eqIdent: first char is case sensitive!!! result.add(params[i][0]) proc isInvalidReturnType(typeName: string): bool = diff --git a/tests/async/tfuturevar.nim b/tests/async/tfuturevar.nim index 9e3134261c..b70f1d1668 100644 --- a/tests/async/tfuturevar.nim +++ b/tests/async/tfuturevar.nim @@ -1,8 +1,3 @@ -discard """ -action: compile -""" -# XXX: action should be run! - import asyncdispatch proc completeOnReturn(fut: FutureVar[string], x: bool) {.async.} =