From 7ae7832f761adc1b601d4d1baa07ce3cc304fb28 Mon Sep 17 00:00:00 2001
From: Jake Leahy <jake@leahy.dev>
Date: Tue, 13 Dec 2022 18:43:37 +1100
Subject: [PATCH] JS backend properly extends string with `setLen` (#21087)

* Add test case

* Extend string with '0' when setting length to be longer
---
 compiler/jsgen.nim  |  4 +++-
 tests/js/t20235.nim | 11 +++++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)
 create mode 100644 tests/js/t20235.nim

diff --git a/compiler/jsgen.nim b/compiler/jsgen.nim
index 42a3dcf312..d8fb6d57df 100644
--- a/compiler/jsgen.nim
+++ b/compiler/jsgen.nim
@@ -2209,7 +2209,9 @@ proc genMagic(p: PProc, n: PNode, r: var TCompRes) =
       if optOverflowCheck notin p.options: binaryExpr(p, n, r, "", "$1 -= $2")
       else: binaryExpr(p, n, r, "subInt", "$1 = subInt($3, $2)", true)
   of mSetLengthStr:
-    binaryExpr(p, n, r, "mnewString", "($1.length = $2)")
+    binaryExpr(p, n, r, "mnewString",
+      """if ($1.length < $2) { for (var i = $3.length; i < $4; ++i) $3.push(0); }
+         else {$3.length = $4; }""")
   of mSetLengthSeq:
     var x, y: TCompRes
     gen(p, n[1], x)
diff --git a/tests/js/t20235.nim b/tests/js/t20235.nim
new file mode 100644
index 0000000000..3a69c2bd61
--- /dev/null
+++ b/tests/js/t20235.nim
@@ -0,0 +1,11 @@
+discard """
+  action: "run"
+  output: "0 4"
+"""
+
+proc main =
+  var s = ""
+  s.setLen(4)
+  echo s[0].ord, " ", s.len
+
+main()