fix #18702(fix parseutils.parseFloat) (#18703) [backport:1.0]

* fix #18702
* Apply suggestions from code review

(cherry picked from commit 901c5ded52)
This commit is contained in:
flywind
2021-08-16 21:14:35 +08:00
committed by narimiran
parent 1802f94868
commit 8d5065453f
2 changed files with 57 additions and 4 deletions

View File

@@ -248,15 +248,16 @@ proc nimParseBiggestFloat(s: string, number: var BiggestFloat,
var ti = 0
let maxlen = t.high - "e+000".len # reserve enough space for exponent
result = i - start
let endPos = i
result = endPos - start
i = start
# re-parse without error checking, any error should be handled by the code above.
if i < s.len and s[i] == '.': i.inc
while i < s.len and s[i] in {'0'..'9','+','-'}:
if i < endPos and s[i] == '.': i.inc
while i < endPos and s[i] in {'0'..'9','+','-'}:
if ti < maxlen:
t[ti] = s[i]; inc(ti)
inc(i)
while i < s.len and s[i] in {'.', '_'}: # skip underscore and decimal point
while i < endPos and s[i] in {'.', '_'}: # skip underscore and decimal point
inc(i)
# insert exponent