From 92488d6ccc938aca3d317c7a7ef559e6ca549712 Mon Sep 17 00:00:00 2001 From: ringabout <43030857+ringabout@users.noreply.github.com> Date: Fri, 1 Aug 2025 22:48:24 +0800 Subject: [PATCH] remove unnecessay conds for nilable strings/seqs --- lib/std/private/miscdollars.nim | 2 +- lib/system/dollars.nim | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/std/private/miscdollars.nim b/lib/std/private/miscdollars.nim index 06fda6fa1a..e6e4d63a70 100644 --- a/lib/std/private/miscdollars.nim +++ b/lib/std/private/miscdollars.nim @@ -26,7 +26,7 @@ template tupleObjectDollar*[T: tuple | object](result: var string, x: T) = result.add(": ") count.inc when compiles($value): - when value isnot string and value isnot seq and compiles(value.isNil): + when compiles(value.isNil): if value.isNil: result.add "nil" else: result.addQuoted(value) else: diff --git a/lib/system/dollars.nim b/lib/system/dollars.nim index e33d6bbc8a..2b5f06415d 100644 --- a/lib/system/dollars.nim +++ b/lib/system/dollars.nim @@ -106,7 +106,7 @@ proc collectionToString[T](x: T, prefix, separator, suffix: string): string = else: result.add(separator) - when value isnot string and value isnot seq and compiles(value.isNil): + when compiles(value.isNil): # this branch should not be necessary if value.isNil: result.add "nil"