From 9ef34c35897bd94aff91dff0d666dc221b8c8b34 Mon Sep 17 00:00:00 2001 From: Juan Carlos Date: Sat, 11 Oct 2025 00:23:40 -0300 Subject: [PATCH] Fix Bisect (#25218) - Nim requires `SSL_library_init`, OpenSSL 3.x removed `SSL_library_init`, Windows defaults to OpenSSL 3.x, then install OpenSSL 1.x on Windows. - Keep `jiro4989/setup-nim-action` at `v1`, because `v2` uses a YAML "hardcoded" matrix of Nim versions, but this Bisect "dynamically" finds the Nim version with a bug, therefore we cant hardcode Nim versions in the YAML, the Bisect programmatically installs required Nim versions as it goes bisecting commit-by-commit. - Update `actions/checkout` from `v4` to `v5`. - Add support for Nim `2.2.4`. @ringabout (cherry picked from commit 1ef81f41902b9f9be1af7b1e93eedb08da9ba5b6) --- .github/workflows/bisects.yml | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/.github/workflows/bisects.yml b/.github/workflows/bisects.yml index 7b3afc72c0..25d601737a 100644 --- a/.github/workflows/bisects.yml +++ b/.github/workflows/bisects.yml @@ -10,10 +10,16 @@ jobs: steps: - uses: actions/checkout@v6 - # nimrun-action requires Nim installed. - - uses: jiro4989/setup-nim-action@v1 - with: - nim-version: 'devel' + - name: Install OpenSSL (Windows) + if: | + runner.os == 'Windows' + run: choco install openssl.light --version=1.1.1.0 # OpenSSL 3.x removed SSL_library_init + shell: 'powershell' + + # v2 wont work here, because uses "hardcoded" nim versions, action "dynamically" finds version with bug. + - uses: jiro4989/setup-nim-action@v1 + with: + nim-version: 'devel' - name: Install Dependencies run: sudo apt-get install --no-install-recommends -yq valgrind