From a519f3b03878e8525a26d726921a58fed6ec94a0 Mon Sep 17 00:00:00 2001 From: Juan Carlos Date: Tue, 30 Jun 2020 11:29:53 -0300 Subject: [PATCH] Removed asyncdispatch.newAsyncNativeSocket, was deprecated since 0.18 (#14854) Co-authored-by: Andreas Rumpf --- changelog.md | 1 + lib/pure/asyncdispatch.nim | 10 ---------- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/changelog.md b/changelog.md index 5f10c5c19b..35c701a8ae 100644 --- a/changelog.md +++ b/changelog.md @@ -185,6 +185,7 @@ proc mydiv(a, b): int {.raises: [].} = - Added the `thiscall` calling convention as specified by Microsoft, mostly for hooking purpose - Deprecated `{.unroll.}` pragma, was ignored by the compiler anyways, was a nop. +- Removed `asyncdispatch.newAsyncNativeSocket`, was deprecated since `0.18`. - Remove `dom.releaseEvents` and `dom.captureEvents`, was deprecated. ## Compiler changes diff --git a/lib/pure/asyncdispatch.nim b/lib/pure/asyncdispatch.nim index a0bc96e721..2ade9065f1 100644 --- a/lib/pure/asyncdispatch.nim +++ b/lib/pure/asyncdispatch.nim @@ -1640,16 +1640,6 @@ proc createAsyncNativeSocket*(domain: Domain = Domain.AF_INET, inheritable = defined(nimInheritHandles)): AsyncFD = createAsyncNativeSocketImpl(domain, sockType, protocol, inheritable) -proc newAsyncNativeSocket*(domain: cint, sockType: cint, - protocol: cint): AsyncFD {.deprecated: "use createAsyncNativeSocket instead".} = - createAsyncNativeSocketImpl(domain, sockType, protocol) - -proc newAsyncNativeSocket*(domain: Domain = Domain.AF_INET, - sockType: SockType = SOCK_STREAM, - protocol: Protocol = IPPROTO_TCP): AsyncFD - {.deprecated: "use createAsyncNativeSocket instead".} = - createAsyncNativeSocketImpl(domain, sockType, protocol) - when defined(windows) or defined(nimdoc): proc bindToDomain(handle: SocketHandle, domain: Domain) = # Extracted into a separate proc, because connect() on Windows requires