From dbe9c724a0817fc7851880871ffd8aca83fa244a Mon Sep 17 00:00:00 2001 From: narimiran Date: Mon, 16 Dec 2024 14:02:04 +0100 Subject: [PATCH] Revert "Bumps `nimble v0.16.4` (#24437)" This reverts commit 1778b8354a54ee22e1fc3652df9c495fa6f0d3d0. --- koch.nim | 10 +++++++--- testament/important_packages.nim | 2 +- tools/deps.nim | 6 ------ 3 files changed, 8 insertions(+), 10 deletions(-) diff --git a/koch.nim b/koch.nim index 246b9371c2..3419fa3487 100644 --- a/koch.nim +++ b/koch.nim @@ -11,7 +11,7 @@ const # examples of possible values for repos: Head, ea82b54 - NimbleStableCommit = "4e7e646b9819b72044e5262c2800e9f7ccfd1b16" # 0.16.4 + NimbleStableCommit = "46e2ae13eeb95619a371a74d16efc5aff30ea371" # 0.16.2 AtlasStableCommit = "5faec3e9a33afe99a7d22377dd1b45a5391f5504" ChecksumsStableCommit = "bd9bf4eaea124bf8d01e08f92ac1b14c6879d8d3" SatStableCommit = "faf1617f44d7632ee9601ebc13887644925dcc01" @@ -156,9 +156,13 @@ proc bundleNimbleExe(latest: bool, args: string) = let commit = if latest: "HEAD" else: NimbleStableCommit cloneDependency(distDir, "https://github.com/nim-lang/nimble.git", commit = commit, allowBundled = true) - updateSubmodules(distDir / "nimble") + cloneDependency(distDir / "nimble" / distDir, "https://github.com/nim-lang/checksums.git", + commit = ChecksumsStableCommit, allowBundled = true) # or copy it from dist? + cloneDependency(distDir / "nimble" / distDir, "https://github.com/nim-lang/sat.git", + commit = SatStableCommit, allowBundled = true) + # installer.ini expects it under $nim/bin nimCompile("dist/nimble/src/nimble.nim", - options = "-d:release --mm:refc --noNimblePath " & args) + options = "-d:release -d:nimNimbleBootstrap --mm:refc --noNimblePath " & args) proc bundleAtlasExe(latest: bool, args: string) = let commit = if latest: "HEAD" else: AtlasStableCommit diff --git a/testament/important_packages.nim b/testament/important_packages.nim index 014285e193..2f5bf8eb1d 100644 --- a/testament/important_packages.nim +++ b/testament/important_packages.nim @@ -30,7 +30,7 @@ type NimblePackage* = object var packages*: seq[NimblePackage] -proc pkg(name: string; cmd = "nimble test -l"; url = "", useHead = true, allowFailure = false) = +proc pkg(name: string; cmd = "nimble test"; url = "", useHead = true, allowFailure = false) = packages.add NimblePackage(name: name, cmd: cmd, url: url, useHead: useHead, allowFailure: allowFailure) pkg "alea" diff --git a/tools/deps.nim b/tools/deps.nim index 6568de7ff2..e43f7a2b42 100644 --- a/tools/deps.nim +++ b/tools/deps.nim @@ -42,9 +42,3 @@ proc cloneDependency*(destDirBase: string, url: string, commit = commitHead, discard "this dependency was bundled with Nim, don't do anything" else: quit "FAILURE: " & destdir & " already exists but is not a git repo" - -proc updateSubmodules*(dir: string) = - let oldDir = getCurrentDir() - setCurrentDir(dir) - exec "git submodule update --init" - setCurrentDir(oldDir)