From fa1a04188ffdc66f1edc909e5b465e548532617a Mon Sep 17 00:00:00 2001 From: Jonah Snider Date: Sun, 27 Dec 2020 00:33:51 -0800 Subject: [PATCH] Avoid creating a holey array in makeNimstrLit for JS target (#16461) * Avoid creating a holey array in makeNimstrLit * Use array index instead of push --- lib/system/jssys.nim | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/system/jssys.nim b/lib/system/jssys.nim index 8865558fe5..e2ceedc2c7 100644 --- a/lib/system/jssys.nim +++ b/lib/system/jssys.nim @@ -189,9 +189,8 @@ proc setConstr() {.varargs, asmNoStackFrame, compilerproc.} = proc makeNimstrLit(c: cstring): string {.asmNoStackFrame, compilerproc.} = {.emit: """ - var ln = `c`.length; - var result = new Array(ln); - for (var i = 0; i < ln; ++i) { + var result = []; + for (var i = 0; i < `c`.length; ++i) { result[i] = `c`.charCodeAt(i); } return result;