From d5cd8e6f71f640ec7b6d9feb369576c9b89de5b8 Mon Sep 17 00:00:00 2001 From: grazil <24716172+grazil@users.noreply.github.com> Date: Thu, 11 Jan 2018 14:16:48 +0100 Subject: [PATCH 1/2] add missing methods in js backend --- lib/js/dom.nim | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/js/dom.nim b/lib/js/dom.nim index aa7f5d8396..6434785025 100644 --- a/lib/js/dom.nim +++ b/lib/js/dom.nim @@ -405,7 +405,7 @@ type # EventTarget "methods" proc addEventListener*(et: EventTarget, ev: cstring, cb: proc(ev: Event), useCapture: bool = false) proc addEventListener*(et: EventTarget, ev: cstring, cb: proc(ev: Event), options: AddEventListenerOptions) - +proc removeEventListener*(et: EventTarget, ev: cstring, cb: proc(ev: Event), useCapture: bool = false) # Window "methods" proc alert*(w: Window, msg: cstring) @@ -507,6 +507,7 @@ proc replace*(loc: Location, s: cstring) proc back*(h: History) proc forward*(h: History) proc go*(h: History, pagesToJump: int) +proc pushState*(h: History, stateObject, title, url: cstring) # Navigator "methods" proc javaEnabled*(h: Navigator): bool From a2b7fcdb4ddf55122f158d54a5364df48187f752 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Renaud=20Ch=C3=A9nard?= <24716172+grazil@users.noreply.github.com> Date: Sun, 14 Jan 2018 23:12:59 +0100 Subject: [PATCH 2/2] Use generic for 'stateObject' in func 'pushState' --- lib/js/dom.nim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/js/dom.nim b/lib/js/dom.nim index 6434785025..55692d47dd 100644 --- a/lib/js/dom.nim +++ b/lib/js/dom.nim @@ -507,7 +507,7 @@ proc replace*(loc: Location, s: cstring) proc back*(h: History) proc forward*(h: History) proc go*(h: History, pagesToJump: int) -proc pushState*(h: History, stateObject, title, url: cstring) +proc pushState*[T](h: History, stateObject: T, title, url: cstring) # Navigator "methods" proc javaEnabled*(h: Navigator): bool