mirrors/Nim
1
0
Fork 0
mirror of https://github.com/nim-lang/Nim.git synced 2026-08-31 02:43:41 +00:00
Code Issues Packages Projects Releases Wiki Activity
23,123 Commits 99 Branches 71 Tags
pr_extend_enum
Commit Graph

14 Commits

Author SHA1 Message Date
ringabout
648f82c2ed fixes semi-regression; discard check now skips nkHiddenSubConv (#23840) 
follow up https://github.com/nim-lang/Nim/pull/23681

ref https://forum.nim-lang.org/t/11987
 2024-07-16 07:37:33 +02:00
ringabout
fe3039410f fixes #23775; injectdestructors now handles discardable statements (#23780) 
fixes #23775
 2024-07-02 08:49:37 +02:00
metagn
42e8472ca6 fix noreturn/implicit discard check logic (#23681) 
fixes #10440, fixes #13871, fixes #14665, fixes #19672, fixes #23677

The false positive in #23677 was caused by behavior in
`implicitlyDiscardable` where only the last node of `if`/`case`/`try`
etc expressions were considered, as in the final node of the final
branch (in this case `else`). To fix this we use the same iteration in
`implicitlyDiscardable` that we use in `endsInNoReturn`, with the
difference that for an `if`/`case`/`try` statement to be implicitly
discardable, all of its branches must be implicitly discardable.
`noreturn` calls are also considered implicitly discardable for this
reason, otherwise stuff like `if true: discardableCall() else: error()`
doesn't compile.

However `endsInNoReturn` also had bugs, one where `finally` was
considered in noreturn checking when it shouldn't, another where only
`nkIfStmt` was checked and not `nkIfExpr`, and the node given for the
error message was bad. So `endsInNoReturn` now skips over
`skipForDiscardable` which no longer contains
`nkIfStmt`/`nkCaseStmt`/`nkTryStmt`, stores the first encountered
returning node in a var parameter for the error message, and handles
`finally` and `nkIfExpr`.

Fixing #23677 already broke a line in `syncio` so some package code
might be affected.
 2024-06-05 20:53:05 +02:00
ringabout
9323cb7b2a enforce void for nkWhileStmt [backport: 2.0] (#21170) 
enforce void for nkWhileStmt
 2022-12-24 10:37:32 +01:00
ringabout
d4afa53fd5 fixes #13583; enforce void for nkWhileStmt (#20947) 
* fixes #13583; enfore void for nkWhileStmt

* one more case
 2022-11-29 06:41:38 +01:00
Andreas Rumpf
fabc2a7086 revert discardable transformation (#10905) 
* Revert "Properly wrap discarded statements (#10322)"

This reverts commit 15584879b9.

* add test for implicit discard after defer
* enable t10241 again
* make C++ tests green again
 2019-04-21 09:57:53 +02:00
Arne Döring
a5ecbf823f lots of small changes 2018-12-11 21:23:22 +01:00
Arne Döring
e012eb1001 updated tests to be executed 2018-11-23 11:58:28 +01:00
Arne Döring
39ad3a0da6 fix #9726 (#9765) 2018-11-20 13:12:47 +01:00
Andreas Rumpf
0926754e68 make tests green again 2018-07-05 15:51:04 +02:00
Arne Döring
000b8afd26 Remove expr/stmt (#5857) 2017-07-25 09:28:23 +02:00
Adam Strzelecki
e80465dacf tests: Trim .nim files trailing whitespace 
via OSX: find . -name '*.nim' -exec sed -i '' -E 's/[[:space:]]+$//' {} +
 2015-09-04 23:04:32 +02:00
Araq
4f946cb44e fixes #942 2014-03-05 08:30:05 +01:00
Araq
20b5f31c03 new tester; all tests categorized 2014-01-13 02:10:03 +01:00