Commit Graph

12 Commits

Author SHA1 Message Date
ASVIEST
20d79c9fb0 Deprecate asm stmt for js target (#23149)
why ?

- We already have an emit that does the same thing
- The name asm itself is a bit confusing, you might think it's an alias
for asm.js or something else.
- The asm keyword is used differently on different compiler targets (it
makes it inexpressive).
- Does anyone (other than some compiler libraries) use asm instead of
emit ? If yes, it's a bit strange to use asm somewhere and emit
somewhere. By making the asm keyword for js target deprecated, there
would be even less use of the asm keyword for js target, reducing the
amount of confusion.
- New users might accidentally use a non-universal approach via the asm
keyword instead of emit, and then when they learn about asm, try to
figure out what the differences are.

see https://forum.nim-lang.org/t/10821

---------

Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
2024-01-02 07:49:54 +01:00
Qinsi (James) ZHU
03dd853815 add .replace() with callback to jsre (#21371) 2023-02-16 18:12:48 +01:00
Juan Carlos
c8000b1025 Add missing symbols to regex (#20383)
* Add missing attribute to jsre

* Add missing attribute to jsre
2022-09-19 17:47:39 -04:00
Juan Carlos
7c31b6a47b Fix jsre (#19917)
* Fixes for jsre to make it more safe at runtime on some edge cases

* https://github.com/nim-lang/Nim/pull/19917#issuecomment-1162692893
2022-06-28 08:13:17 +02:00
Juan Carlos
fe791c67b4 Remove Deprecated jsre func (#19551)
* Remove Deprecated jsre func

* Remove Deprecated jsre func

* ReStart CI, because OSX is dumb and I have no permission to restart
2022-02-25 10:43:35 +01:00
Yanis Zafirópulos
a55c7e9679 WIP: Added missing functions to jsre module (#17881)
* added missing functions: `replace`, `replaceAll`, `split`, `match`
* added `startsWith` & `endsWith`
* Update lib/js/jsre.nim

Co-authored-by: Juan Carlos <juancarlospaco@gmail.com>
2021-05-01 09:37:02 +02:00
Juan Carlos
fb38d906a2 Improve jsre (#17365)
* Add dollar for regex

* Add dollar for regex

* Peer review feedbacks

* Peer review feedbacks

* Update lib/js/jsre.nim

Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>

* Update lib/js/jsre.nim

Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>

* Update lib/js/jsre.nim

Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>

* Pear review

* Beer review

* Beer review

Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>
2021-03-21 10:35:55 +01:00
flywind
fe20492f05 clean up the docs of some modules under lib/js (#16579) 2021-01-04 19:54:33 +01:00
flywind
148d614dff js module also uses runnableExamples (#16229) 2020-12-02 16:24:59 +01:00
Juan Carlos
c4e03b540e Fix #15183 (#15300) 2020-09-11 08:57:57 +02:00
Miran
4b93c61f0d jsre: try to fix nightlies (#15057) 2020-07-24 21:15:20 +02:00
Juan Carlos
4f6acf24ff Add jsre (#14870) 2020-07-03 20:13:10 +02:00