Commit Graph

5147 Commits

Author SHA1 Message Date
Adrian Veith
5a3456d220 fix for #18284 int32 should be int (#18285)
the var exp was typed as int32 - it should be int since frep expects an int
2021-06-17 11:23:38 +02:00
flywind
c51680e701 fixes #17696 (#18276) 2021-06-16 11:31:20 +02:00
Mark Pointing
e80d7ff0f2 httpclient.nim Fixes #14794 and an issue where content-header is not set on postContent (#18208)
* Fixed missing newline after bound marker in mulipart post (#14794) and a problem where calling postContent with multipart data does not set content-length header.

* Update lib/pure/httpclient.nim

* Added comment outlining the reason for changes to httpclient.nim and added tests to ensure that multipart post has a newline at the end of the body, and that the content-length header is present.

* Fixed typo in comments.

* Removed redundant blank lines in thttpclient_standalone.nim.

Co-authored-by: Mark Pointing <mark@futurepoint.com.au>
Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
2021-06-14 19:29:23 +02:00
Federico Ceratto
a266c54921 Improve httpClient docs on SSL cert verification (#15201)
* Improve httpClient docs on SSL cert verification

Cert verification is enabled by default after CVE-2021-29495

* Update httpclient.nim

Co-authored-by: Dominik Picheta <dominikpicheta@googlemail.com>
2021-06-13 16:50:04 +01:00
Fröhlich A
7bf0404dd8 #18216 make moveDir work across partitions on windows (#18223)
* return false if AccessDeniedError in tryMoveFSObject - fixes #18216

* add moveDir & moveFile tests

* rename `isMoveDir` parameter to `isDir`
2021-06-10 14:28:00 +02:00
Andreas Rumpf
0a4858dc59 fixes #18220 (#18227) 2021-06-10 09:25:51 +02:00
Andreas Rumpf
21f3b8539a fixes #18088 (#18209) 2021-06-07 17:22:35 +02:00
Bung
429b128632 change mimedb stroe stringtable to orderedtable (#18065)
* change mimedb stroe stringtable to orderedtable

* Update lib/pure/mimetypes.nim

Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
2021-06-07 13:57:42 +02:00
Timothee Cour
cc7ec5a6a4 fix #7295: use move(result) inside template to avoid copy with --gc:refc (#18168) 2021-06-04 15:32:46 -07:00
flywind
a77360da5b workaround bug in sharedtables.withValue to unblock frozen CI on OSX (#18172) 2021-06-04 12:41:13 -07:00
flywind
d31cbfd167 Revert "add missing import to asynchttpserver's example" (#18164)
This reverts commit 7ef364a402.
2021-06-03 16:44:11 +02:00
narimiran
7ef364a402 add missing import to asynchttpserver's example 2021-06-03 15:20:42 +02:00
n5m
9df631a379 reuse algorithm.fill while building SkipTable (#18138)
* reuse algorithm.fill while building SkipTable

* Update lib/pure/strutils.nim

Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>

Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>
2021-06-03 14:25:52 +02:00
flywind
06960bb9cb Ref #17697 improve withValue docs (#18154)
* Ref #17697 improve withValue docs

* address comments
2021-06-03 07:35:24 +02:00
flywind
bbce3d2da9 [std/tables] remove unnecessary do: (#18160) 2021-06-02 21:09:04 -07:00
flywind
f27f3f65df [std/hashcommon]improve docs a bit (#18153)
* reduce duplicated deprecated messages
2021-06-02 22:59:06 -04:00
Timothee Cour
9559350e34 add os.getCacheDir (#18126)
* add `os.getCacheDir`

* fixup

* address comments
2021-05-31 22:16:33 +02:00
n5m
064fe18de6 improve fast returns of find and rfind (#18127) 2021-05-31 11:20:15 +02:00
Miran
50e98e6efa hashes for refs should be an opt-in feature (#18098) 2021-05-30 23:55:51 +02:00
Timothee Cour
4a7f2c386c close #16569: deprecated reversed(a, start, last) overload, use toOpenArray instead (#18047)
* close #16569: deprecated reversed overload, use toOpenArray instead

* [skip ci] change wording in changelog per review

* fixup
2021-05-30 22:37:21 +02:00
xioren
478f717377 Move async example to asynchronous version of proc (#18078)
* improve runnableExamples in std/httpclient

* Add synchronous example.

* Update lib/pure/httpclient.nim

Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>
2021-05-24 20:56:31 -07:00
Timothee Cour
d217888e56 close #18009 parseJson JInt vs JFloat; preserve -0.0 as JFloat to distinguish from 0.0 (#18067) 2021-05-23 23:06:14 +02:00
Ștefan Talpalaru
a1c82c39af asyncdispatch+stackTraceOverride: fix premature collection (#18039) [backport:1.2]
Copying StackTraceEntry instances when nimStackTraceOverride is defined
breaks the link between a cstring field that's supposed to point at
another string field in the same object.

Sometimes, the original object is garbage collected, that memory region
reused for storing other strings, so when the StackTraceEntry copy tries
to use its cstring pointer to construct a traceback message, it accesses
unrelated strings.

This only happens for async tracebacks and this patch prevents that by
making sure we only use the string fields when nimStackTraceOverride is
defined.

Async tracebacks also beautified slightly by getting rid of an extra line
that was supposed to be commented out, along with the corresponding debugging output.

There's also a micro-optimisation to avoid concatenating two strings just
to get their combined length.
2021-05-19 19:19:11 +02:00
Andreas Rumpf
7052503ca8 make strformat part of the prelude (#18046) 2021-05-19 19:18:16 +02:00
Antonis Geralis
6e0fe965da add sink and lent annotations for xmltree and streams (#18037) 2021-05-18 08:16:07 +02:00
Timothee Cour
d83b25db1e fix #18007: std/json now serializes nan,inf,-inf as strings instead of invalid json (#18026)
* fix #18007: std/json now serializes nan,inf,-inf as raw strings instead of invalid json

* fix roundtrip

* fix tests

* fix changelog

* simplify

* add runnableExamples

* fix typo [skip ci]
2021-05-16 23:54:10 +02:00
Timothee Cour
45490497e3 fix #17467 1st call to rand is now non-skewed; allow seed == 0 (#17468)
* fix #17467 1st call to rand is now non-skewed; allow passing 0 as seed

* changelog + fallback

* document behavior for seed == 0

* address comments

* _

* fix tests, disable kdtree

* re-enable kdtree with -d:nimLegacyRandomInitRand
2021-05-11 11:04:59 +02:00
Andreas Rumpf
983a2aa11c Revert "Fix parseUri to sanitize urls containing ASCII newline or tab (#17967)" (#17984)
This reverts commit f4dd95f3be.
2021-05-09 23:33:31 +02:00
Beshr Kayali
f4dd95f3be Fix parseUri to sanitize urls containing ASCII newline or tab (#17967)
* Fix parseUri to sanitize urls containing ASCII newline or tab

* Fix ups based on review

Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>

* Additional fix ups based on review

- Avoid unnecessary `removeUnsafeBytesFromUri` call if parseUri is strict
- Move some parseUri tests to uri module test file

Co-authored-by: Dominik Picheta <dominikpicheta@googlemail.com>

* Update changelog

Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>
Co-authored-by: Dominik Picheta <dominikpicheta@googlemail.com>
2021-05-09 19:24:00 +01:00
Timothee Cour
eba1c3fd24 merge initUri() overloads, improve uri examples (#17970)
* deprecate `uri.initUri` and improve uri examples

* remove `func initUri*()` and make isIpv6 optional

* fixup
2021-05-08 16:58:30 +02:00
Andreas Rumpf
c14427dbf3 ORC: cursor inference bugfix (#17973)
* fixed a .cursor inference bug

* added a test case
2021-05-08 16:47:06 +02:00
Timothee Cour
38b41f893a fix #17941: UnusedImport works for var/let/const/type invoked inside a generic (#17942)
* fix #17941: UnusedImport works for var/let/const/type invoked inside a generic

* fixup
2021-05-08 09:56:46 +02:00
Ardek Romak
9d86639a0b Export sslHandle in net and asyncnet. (#17573) 2021-05-06 15:02:37 -07:00
Juan Carlos
bf5dfe481a parsecsv fix style (#17933)
* ReSync with Devel
* Fix style in parsecsv
* Update lib/pure/parsecsv.nim

Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
2021-05-04 13:13:23 +02:00
Timothee Cour
78e2d299df typo: nonexistant => nonexistent (#17918)
* typo: nonexistant => nonexistent

* fix test (ordering differs because of https://github.com/nim-lang/Nim/issues/17910)
2021-05-02 00:26:41 +02:00
Timothee Cour
ee6d56141c fix #17911 rawProc for cpp (#17912) 2021-05-01 11:12:13 +02:00
Andreas Rumpf
fb86271556 system.nim cleanup some exported constants which should never have be… (#17909)
* system.nim cleanup some exported constants which should never have been exported
2021-05-01 11:10:40 +02:00
flywind
9f75e8abc1 [std/base64] uses runnableExamples (#17882)
* [std/base64] uses runnableExamples
* Update lib/pure/base64.nim

Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>
2021-05-01 07:27:50 +02:00
Timothee Cour
d32ab61e61 fix #17905: hash(closure) was not being tested (#17906) 2021-04-30 12:40:39 -07:00
Timothee Cour
e4db733d80 fix #17888: remove undefined behavior for posix.open; fix tempfiles.createTempFile (#17889)
* fix #17888: remove undefined behavior for posix.open; fix tempfiles.createTempFile

* fix for tests/async/tasyncfile.nim

* hide mode for now

* add notice regarding stability
2021-04-29 13:42:56 +02:00
flywind
5edddd68d0 improve cache line size (#17885)
* improve cache line size

- 64bit system tend to use cache line of 64 bytes
- add align

https://trishagee.com/2011/07/22/dissecting_the_disruptor_why_its_so_fast_part_two__magic_cache_line_padding


Though I'm not sure, what do you think? @timotheecour

* Update lib/pure/concurrency/threadpool.nim
2021-04-29 13:39:36 +02:00
flywind
016a8ccd7a [std/encodings]move to tests (#17866) 2021-04-29 09:51:54 +02:00
Michael Krieger
7637cff9cf Fix documentation of strutils.stripLineEnd (#17883)
It does not return anything.
2021-04-28 11:33:08 -07:00
flywind
d881a05bf6 [std/encodings] fix iconv headers on OpenBSD (#17872) 2021-04-27 10:14:26 -07:00
flywind
66022423aa [std/pegs] increase test coverage (#17871) 2021-04-27 11:09:58 +02:00
flywind
b1c7c994b0 [std/parsecfg]use runnableExamples (#17868)
* [std/parsecfg]use runnableExamples
* Apply suggestions from code review

Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>
2021-04-27 10:24:59 +02:00
Timothee Cour
3f58b7face add -d:nimLegacyNoHashRef for a transition period which avoids defining hash(ref) (#17858) 2021-04-27 08:23:01 +02:00
flywind
01bca8cd4f fix gbk encodings on windows (#17843) 2021-04-26 14:48:25 +02:00
flywind
68e522ecec Remove confusing <//> (#17830) 2021-04-26 09:04:52 +02:00
flywind
6e8f0f8cfc add colon (#17834) 2021-04-24 18:33:29 +01:00