Commit Graph

24 Commits

Author SHA1 Message Date
alaviss
22418ce8fb tools/finish: don't quote path with space (#14058) [backport]
Path with spaces should be added as is, quoting them makes utilities
treat the quotes as part of the path. This makes `nim` unable to be used
from the command line even if it appears to be added to user's Path
environment variable.

Even more confusing, Windows 10's PATH editor shows the path without any
quotes, you only see them when you use "Edit text". Took me a good 15
minutes to figure out why couldn't I run `nim` despite it being in Path.
2020-04-22 07:51:18 +02:00
Gampol T
83b7656c0e fixes #12319 - change exception handling for finish.exe (#12413)
* documented behaviour of recv on bufferd socket

* fixes #12319- check exception using errorCode
2019-11-15 13:28:55 +01:00
genotrance
0c7b6c9c15 Switch mingw links (#12561) 2019-10-31 11:13:32 +01:00
Araq
b9dd972c32 fixes #11770 2019-08-16 14:48:32 +02:00
Andreas Rumpf
6ce6bce12e fixes a finish.exe regression 2019-07-06 22:48:22 +02:00
Matt Haggard
fd62d24c4c Add non-interactive installer flag (-y) to finish.nim (#10603) [backport] 2019-02-08 09:39:58 +01:00
Ganesh Viswanathan
9bde9a1404 Add nimble dir to path via finish 2018-05-09 17:39:42 +02:00
genotrance
452321874d Fixes for #7747 - finish.exe issues (#7748) 2018-05-02 19:16:44 +02:00
Araq
5ee9e86c87 fixes finish.nim download bug 2018-03-01 22:38:41 +01:00
Araq
82870058d3 finish.nim: make it work with spaces in the path to curl 2017-12-02 00:57:13 +01:00
Araq
7e07fc5893 finish.nim tool: make path environment creation more robust 2017-09-30 15:37:36 +02:00
Araq
6857363034 finish.nim tool: use global path environment variable if local does not exist 2017-05-17 21:48:36 +02:00
Araq
7d1a96151c finish tool can use 'nimgrab' tool to download the mingw version 2017-02-26 23:25:50 +01:00
Araq
c8ae7164e5 finish.nim: user has multiple chances to move .7z file to proper location 2017-02-11 00:24:22 +01:00
Araq
ca42406df9 finish.nim: final round of improvements 2017-02-08 12:44:49 +01:00
Araq
25fb5be0cb finish tool improvements 2017-02-06 22:06:52 +01:00
Araq
5d79a1fc5b finish.nim: yet another GCC detection problem fixed 2017-01-30 09:43:32 +01:00
Andreas Rumpf
5421ec8dae finish tool: untested improvements to the GCC detection logic 2017-01-26 11:26:02 +01:00
Araq
26a8364ed7 downloader tool works 2017-01-23 00:36:39 +01:00
Andreas Rumpf
e216e0debd finish tool: untested download feature 2017-01-15 10:12:28 +01:00
Andreas Rumpf
e142f4c371 finish tool: slightly more informative error message 2017-01-13 12:07:37 +01:00
Araq
4134240b42 finish tool: Check for installations in 'program files' et al 2016-12-29 19:20:23 +01:00
Araq
33ebf3e5fb fixes criticial finish.nim bug 2016-11-03 14:43:24 +01:00
Araq
9d2dfa9a99 further cleanups; refs #4934 2016-10-24 12:20:51 +02:00