mirror of
https://github.com/nim-lang/Nim.git
synced 2025-12-28 08:54:53 +00:00
720d0aee5c
Testament now retries a test by a specified amount if it fails in any way other than an invalid spec. This is to deal with the flaky GC tests on Windows CI that fail in many different ways, from the linker randomly erroring, segfaults, etc. Unfortunately I couldn't do this cleanly in testament's current code. The proc `addResult`, which is the "final" proc called in a test run's lifetime, is now wrapped in a proc `finishTest` that returns a bool `true` if the test failed and has to be retried. This result is propagated up from `cmpMsgs` and `compilerOutputTests` until it reaches `testSpecHelper`, which handles these results by recursing if the test has to be retried. Since calling `testSpecHelper` means "run this test with one given configuration", this means every single matrix option/target etc. receive an equal amount of retries each. The result of `finishTest` is ignored in cases where it's known that it won't be retried due to passing, being skipped, having an invalid spec etc. It's also ignored in `testNimblePackages` because it's not necessary for those specific tests yet and similar retry behavior is already implemented for part of it. This was a last resort for the flaky GC tests but they've been a problem for years at this point, they give us more work to do and turn off contributors. Ideally GC tests failing should mark as "needs review" in the CI rather than "failed" but I don't know if Github supports something like this.
61 lines
1.2 KiB
Nim
61 lines
1.2 KiB
Nim
discard """
|
|
outputsub: "77\n77"
|
|
retries: 2
|
|
"""
|
|
|
|
## Check how GC/Alloc works in Emscripten
|
|
import strutils
|
|
|
|
type
|
|
X = ref XObj
|
|
XObj = object
|
|
name: string
|
|
value: int
|
|
when defined(allow_print):
|
|
const print = true
|
|
else:
|
|
const print = false
|
|
|
|
proc myResult3*(i:int): X {.exportc.} =
|
|
if print: echo "3"
|
|
new(result)
|
|
if print: echo "3-2"
|
|
result.value = i
|
|
|
|
proc myResult5*(i:int, x:X):X {.exportc.} =
|
|
if print: echo "5"
|
|
system.GC_fullCollect()
|
|
new(result)
|
|
if print: echo "5-2"
|
|
result.value = i
|
|
x.value = i+1
|
|
if result.value == x.value:
|
|
echo "This should not happen. Just allocated variable points to parameter"
|
|
|
|
proc myResult2*(val: string, i: int): X {.exportc.} =
|
|
if print: echo "2-1"
|
|
result = myResult3(i)
|
|
if print: echo "2-2"
|
|
system.GC_fullCollect()
|
|
if print: echo "2-3"
|
|
var t = new(X)
|
|
if print: echo "2-4"
|
|
result.name = val
|
|
if t.name == "qwe":
|
|
echo "This should not happen. Variable is GC collected and new one on same place are allocated."
|
|
if print: echo "2-5"
|
|
|
|
proc myResult4*(val: string, i: int): X {.exportc.} =
|
|
if print: echo "4-1"
|
|
result = myResult5(i, X())
|
|
if print: echo "4-2"
|
|
|
|
var x = myResult2("qwe", 77)
|
|
echo intToStr(x.value)
|
|
|
|
var x2 = myResult4("qwe", 77)
|
|
echo intToStr(x2.value)
|
|
|
|
|
|
|