mirror of
https://github.com/nim-lang/Nim.git
synced 2026-01-03 19:52:36 +00:00
24a606902a
fixes #23247 closes #23251 (which accounts for why the openarray type is lifted because ops are lifted for openarray conversions) related: https://github.com/nim-lang/Nim/pull/18713 It seems to me that openarray doesn't own the data, so it cannot destroy itself. The same case should be applied to https://github.com/nim-lang/Nim/issues/19435. It shouldn't be destroyed even openarray can have a destructor. A cleanup will be followed for https://github.com/nim-lang/Nim/pull/19723 if it makes sense. According to https://github.com/nim-lang/Nim/pull/12073, it lifts destructor for openarray when openarray is sunk into the function, when means `sink openarray` owns the data and needs to destroy it. In other cases, destructor shouldn't be lifted for `openarray` in the first place and it shouldn't destroy the data if it doesn't own it. --------- Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
52 lines
1.3 KiB
Nim
52 lines
1.3 KiB
Nim
discard """
|
|
matrix: ";-d:useMalloc"
|
|
"""
|
|
|
|
# bug #23247
|
|
import std/hashes
|
|
|
|
func baseAddr[T](x: openArray[T]): ptr T =
|
|
# Return the address of the zero:th element of x or `nil` if x is empty
|
|
if x.len == 0: nil else: cast[ptr T](x)
|
|
|
|
func makeUncheckedArray[T](p: ptr T): ptr UncheckedArray[T] =
|
|
cast[ptr UncheckedArray[T]](p)
|
|
|
|
type
|
|
LabelKey = object
|
|
data: seq[string]
|
|
refs: ptr UncheckedArray[string]
|
|
refslen: int
|
|
|
|
Gauge = ref object
|
|
metrics: seq[seq[seq[string]]]
|
|
|
|
template values(key: LabelKey): openArray[string] =
|
|
if key.refslen > 0:
|
|
key.refs.toOpenArray(0, key.refslen - 1)
|
|
else:
|
|
key.data
|
|
|
|
proc hash(key: LabelKey): Hash =
|
|
hash(key.values)
|
|
|
|
proc view(T: type LabelKey, values: openArray[string]): T =
|
|
# TODO some day, we might get view types - until then..
|
|
LabelKey(refs: baseAddr(values).makeUncheckedArray(), refslen: values.len())
|
|
|
|
template withValue2(k: untyped) =
|
|
discard hash(k)
|
|
|
|
proc setGauge(
|
|
collector: Gauge,
|
|
labelValues: openArray[string],
|
|
) =
|
|
let v = LabelKey.view(labelValues)
|
|
withValue2(v)
|
|
collector.metrics.add @[@labelValues, @labelValues]
|
|
discard @labelValues
|
|
|
|
var nim_gc_mem_bytes = Gauge()
|
|
let threadID = $getThreadId()
|
|
setGauge(nim_gc_mem_bytes, @[threadID])
|
|
setGauge(nim_gc_mem_bytes, @[threadID]) |