mirror of
https://github.com/nim-lang/Nim.git
synced 2026-01-04 12:07:51 +00:00
720d0aee5c
Testament now retries a test by a specified amount if it fails in any way other than an invalid spec. This is to deal with the flaky GC tests on Windows CI that fail in many different ways, from the linker randomly erroring, segfaults, etc. Unfortunately I couldn't do this cleanly in testament's current code. The proc `addResult`, which is the "final" proc called in a test run's lifetime, is now wrapped in a proc `finishTest` that returns a bool `true` if the test failed and has to be retried. This result is propagated up from `cmpMsgs` and `compilerOutputTests` until it reaches `testSpecHelper`, which handles these results by recursing if the test has to be retried. Since calling `testSpecHelper` means "run this test with one given configuration", this means every single matrix option/target etc. receive an equal amount of retries each. The result of `finishTest` is ignored in cases where it's known that it won't be retried due to passing, being skipped, having an invalid spec etc. It's also ignored in `testNimblePackages` because it's not necessary for those specific tests yet and similar retry behavior is already implemented for part of it. This was a last resort for the flaky GC tests but they've been a problem for years at this point, they give us more work to do and turn off contributors. Ideally GC tests failing should mark as "needs review" in the CI rather than "failed" but I don't know if Github supports something like this.
90 lines
2.3 KiB
Nim
90 lines
2.3 KiB
Nim
discard """
|
|
output: '''
|
|
Hello from thread
|
|
Hello from thread
|
|
Hello from thread
|
|
Hello from thread
|
|
'''
|
|
cmd: "nim $target --hints:on --threads:on --tlsEmulation:off $options $file"
|
|
retries: 2
|
|
"""
|
|
# Copied from stdlib
|
|
import strutils
|
|
|
|
const
|
|
StackGuardSize = 4096
|
|
ThreadStackMask = 1024*256*sizeof(int)-1
|
|
ThreadStackSize = ThreadStackMask+1 - StackGuardSize
|
|
|
|
type ThreadFunc = proc() {.thread.}
|
|
|
|
when defined(posix):
|
|
import posix
|
|
|
|
proc runInForeignThread(f: ThreadFunc) =
|
|
proc wrapper(p: pointer): pointer {.noconv.} =
|
|
let thr = cast[ThreadFunc](p)
|
|
setupForeignThreadGc()
|
|
thr()
|
|
tearDownForeignThreadGc()
|
|
setupForeignThreadGc()
|
|
thr()
|
|
tearDownForeignThreadGc()
|
|
result = nil
|
|
|
|
var attrs {.noinit.}: PthreadAttr
|
|
doAssert pthread_attr_init(addr attrs) == 0
|
|
doAssert pthread_attr_setstacksize(addr attrs, ThreadStackSize) == 0
|
|
var tid: Pthread
|
|
doAssert pthread_create(addr tid, addr attrs, wrapper, f) == 0
|
|
doAssert pthread_join(tid, nil) == 0
|
|
|
|
elif defined(windows):
|
|
import winlean
|
|
type
|
|
WinThreadProc = proc (x: pointer): int32 {.stdcall.}
|
|
|
|
proc createThread(lpThreadAttributes: pointer, dwStackSize: DWORD,
|
|
lpStartAddress: WinThreadProc,
|
|
lpParameter: pointer,
|
|
dwCreationFlags: DWORD,
|
|
lpThreadId: var DWORD): Handle {.
|
|
stdcall, dynlib: "kernel32", importc: "CreateThread".}
|
|
|
|
proc wrapper(p: pointer): int32 {.stdcall.} =
|
|
let thr = cast[ThreadFunc](p)
|
|
setupForeignThreadGc()
|
|
thr()
|
|
tearDownForeignThreadGc()
|
|
setupForeignThreadGc()
|
|
thr()
|
|
tearDownForeignThreadGc()
|
|
result = 0'i32
|
|
|
|
proc runInForeignThread(f: ThreadFunc) =
|
|
var dummyThreadId: DWORD
|
|
var h = createThread(nil, ThreadStackSize.int32, wrapper.WinThreadProc, cast[pointer](f), 0, dummyThreadId)
|
|
doAssert h != 0.Handle
|
|
doAssert waitForSingleObject(h, -1'i32) == 0.DWORD
|
|
|
|
else:
|
|
{.fatal: "Unknown system".}
|
|
|
|
proc runInNativeThread(f: ThreadFunc) =
|
|
proc wrapper(f: ThreadFunc) {.thread.} =
|
|
# These operations must be NOP
|
|
setupForeignThreadGc()
|
|
tearDownForeignThreadGc()
|
|
f()
|
|
f()
|
|
var thr: Thread[ThreadFunc]
|
|
createThread(thr, wrapper, f)
|
|
joinThread(thr)
|
|
|
|
proc f {.thread.} =
|
|
var msg = "Hello " & "from thread"
|
|
echo msg
|
|
|
|
runInForeignThread(f)
|
|
runInNativeThread(f)
|