mirror of
https://github.com/nim-lang/Nim.git
synced 2026-06-10 05:38:10 +00:00
f959a02037
fixes #25725 This pull request makes significant improvements to symbol handling during transformation passes in the compiler, particularly for routines (procedures, iterators) and their parameters. The changes ensure that when routines are copied (for inlining, closure generation, etc.), all relevant symbols and type headers are also freshly copied and correctly owned, preventing subtle bugs from symbol reuse. Additionally, new regression tests are added to cover previously problematic iterator cases. **Improvements to symbol copying and ownership:** * Introduced `freshOwnedSym` to create a fresh copy of a symbol with a specified owner, ensuring that transformed routines and their parameters do not share symbols with the originals, which prevents accidental aliasing and ownership issues. * Refactored `freshVar` to use `freshOwnedSym`, centralizing fresh symbol creation logic. * Added `introduceNewRoutineHeaderSyms` and `copyRoutineTypeHeader` to ensure that when routines are copied, all parameter/result symbols and their types are also freshly copied and mapped, avoiding shared state between original and transformed routines. * Updated `introduceNewLocalVars` to use `freshOwnedSym` for routine symbols and to invoke the new header/type copying procedures, ensuring correctness in routine transformation. **Testing and regression coverage:** * Added new blocks to `tests/iter/titer_issues.nim` to test iterator transformation edge cases, including scenarios that previously led to symbol reuse bugs (e.g., bugs #25724 and #25725).
This directory contains the test cases.
Each test must have a filename of the form: t*.nim
Note: Testament is only aware of tests under a directory (eg tests/foo/) and will ignore
top-level tests like tests/tbar.nim.
Specs
Each test can contain a spec in a discard """ ... """ block.
Check out the parseSpec procedure in the specs module for a full and reliable reference
action
Specifies what action this test should take.
Default: run
Options:
compile- compiles the module and fails the test if compilations fails.run- compiles and runs the module, fails the test if compilation or execution of test code fails.reject- compiles the module and fails the test if compilation succeeds.
There are certain spec keys that imply run, including output and
outputsub.
Categories
Each folder under this directory represents a test category, which can be
tested by running koch tests pcat <category> (or cat to avoid parallel
testing, which is slower).
The folder dll contains simple DLL tests.
The folder realtimeGC contains a test for validating that the realtime GC
can run properly without linking against the nimrtl.dll/so.