ringabout
5a50254213
fixes #22950 ; Poor error message on cast effect violation ( #25839 )
...
fixes #22950
This pull request improves the tracking and reporting of effect
annotations (such as `raises`, `tags`, and `forbids`) in pragma blocks,
particularly when using the `cast` pragma. It ensures that the source of
these effect annotations is correctly preserved and referenced, which
improves error reporting and effect analysis. Additionally, a new test
was added to check for violations when using `cast` with effect
annotations.
Effect annotation source tracking and propagation:
* Added new fields (`excSource`, `tagsSource`, `forbidsSource`) to the
`PragmaBlockContext` type to store the original source node for each
effect annotation.
* Updated `castBlock` to set these new source fields when processing
`raises`, `tags`, and `forbids` pragmas, ensuring the source node is
preserved for later error reporting.
* Modified `unapplyBlockContext` to use the stored source node (if
available) when calling `addRaiseEffect`, `addTag`, and `addNotTag`,
improving the accuracy of effect tracking and diagnostics.
Pragma handling improvements:
* Changed the call to `castBlock` in the main pragma processing loop to
pass the entire pragma node, enabling access to the original source for
effect annotations.
Testing:
* Added a new test (`tests/effects/tcast_effect_violation.nim`) to
verify that using `cast(raises: ValueError)` inside a procedure with
`.raises: [].` correctly triggers an error message about an unlisted
exception.
(cherry picked from commit cfa769fefc )
2026-05-28 09:22:27 +02:00
..
2025-01-14 07:46:40 +01:00
2024-03-18 20:27:00 +01:00
2023-08-06 14:26:21 +02:00
2023-12-15 10:20:57 +01:00
2025-11-21 13:28:13 +01:00
2025-05-06 16:04:43 +02:00
2026-01-09 09:03:51 +01:00
2024-04-16 12:46:59 +02:00
2024-07-12 15:23:09 +02:00
2023-10-11 17:44:14 +02:00
2023-08-06 14:26:21 +02:00
2024-09-27 11:12:39 +02:00
2025-04-02 09:42:57 +02:00
2026-04-20 09:45:51 +02:00
2022-09-28 15:05:01 +02:00
2022-11-30 21:51:13 +01:00
2025-10-08 08:33:16 +02:00
2026-05-22 08:58:11 +02:00
2024-07-12 15:23:09 +02:00
2024-07-12 15:23:09 +02:00
2026-03-09 10:47:45 +01:00
2025-03-18 08:49:45 +01:00
2026-01-09 08:49:03 +01:00
2026-05-08 14:55:56 +02:00
2025-01-14 07:46:40 +01:00
2026-03-17 10:12:06 +01:00
2024-03-28 11:04:12 +01:00
2026-05-08 15:17:50 +02:00
2023-06-18 16:06:14 +02:00
2026-01-09 09:03:51 +01:00
2026-02-02 07:59:57 +01:00
2017-01-07 22:35:09 +01:00
2022-06-10 20:40:08 +02:00
2023-10-29 14:48:11 +01:00
2026-01-09 09:03:51 +01:00
2025-04-02 09:43:12 +02:00
2023-08-06 14:26:21 +02:00
2026-03-30 15:09:59 +02:00
2025-04-18 12:50:05 +02:00
2023-11-20 21:12:13 +01:00
2025-01-14 07:46:40 +01:00
2025-01-14 07:46:40 +01:00
2024-08-28 20:46:36 +02:00
2025-07-17 13:39:17 +02:00
2023-10-29 14:48:11 +01:00
2023-10-29 14:48:11 +01:00
2023-10-29 14:48:11 +01:00
2025-01-14 07:46:40 +01:00
2025-11-22 13:33:01 +01:00
2023-10-29 14:48:11 +01:00
2026-05-08 15:17:50 +02:00
2020-06-01 19:21:41 +02:00
2026-03-09 10:13:31 +01:00
2025-10-14 11:37:24 +02:00
2023-12-15 08:13:25 +01:00
2025-01-15 10:21:20 +01:00
2026-04-20 09:45:28 +02:00
2025-07-17 13:39:41 +02:00
2026-04-07 08:34:55 +02:00
2026-01-09 09:03:51 +01:00
2023-12-13 10:39:10 +01:00
2026-05-22 08:57:23 +02:00
2026-04-03 12:47:11 +02:00
2025-01-14 07:46:40 +01:00
2026-03-23 09:10:29 +01:00
2026-01-26 09:13:17 +01:00
2025-03-25 09:44:55 +01:00
2025-09-22 08:48:48 +02:00
2025-01-14 07:46:40 +01:00
2021-01-12 09:36:51 +01:00
2026-03-09 10:13:04 +01:00
2024-07-09 09:29:45 +02:00
2024-04-05 08:54:48 +02:00
2026-01-09 09:03:51 +01:00
2025-06-06 08:32:58 +02:00
2025-01-14 07:45:59 +01:00
2026-01-26 09:13:17 +01:00
2025-01-14 07:46:40 +01:00
2026-02-26 17:32:51 +01:00
2024-07-17 18:25:19 +02:00
2023-12-15 08:13:25 +01:00
2025-10-27 08:51:00 +01:00
2024-04-10 14:41:16 +02:00
2023-10-29 14:48:11 +01:00
2023-10-29 14:48:11 +01:00
2025-01-14 07:46:40 +01:00
2023-10-29 14:48:11 +01:00
2024-08-12 15:33:26 +02:00
2023-04-17 20:55:22 +02:00
2025-04-04 10:08:30 +02:00
2026-02-26 17:27:01 +01:00
2023-08-06 14:26:21 +02:00
2025-01-14 07:34:32 +01:00
2025-09-24 08:54:39 +02:00
2025-07-17 13:39:26 +02:00
2022-08-24 09:44:16 +02:00
2025-01-14 07:51:55 +01:00
2023-10-29 14:48:11 +01:00
2025-04-14 10:52:41 +02:00
2025-04-14 10:52:50 +02:00
2023-03-03 07:36:38 +01:00
2025-10-14 11:37:24 +02:00
2018-05-27 19:19:12 +02:00
2025-04-14 10:53:01 +02:00
2023-10-29 14:48:11 +01:00
2024-04-10 14:41:16 +02:00
2024-09-03 09:19:52 +02:00
2023-07-02 22:36:05 +02:00
2026-04-16 19:44:36 +02:00
2023-10-29 14:48:11 +01:00
2025-04-14 10:52:41 +02:00
2023-11-06 18:33:28 +01:00
2023-08-10 14:26:40 +02:00
2020-09-11 01:04:07 +02:00
2023-10-29 14:48:11 +01:00
2025-10-28 13:50:50 +01:00
2026-04-13 12:06:27 +02:00
2026-04-09 18:12:45 +02:00
2026-05-08 15:14:04 +02:00
2025-03-03 14:10:49 +01:00
2026-01-12 08:48:55 +01:00
2025-05-05 08:19:11 +02:00
2025-04-21 19:09:45 +02:00
2025-09-22 08:47:23 +02:00
2026-05-08 15:07:34 +02:00
2025-10-17 09:24:11 +02:00
2025-01-14 07:46:40 +01:00
2026-05-28 09:22:27 +02:00
2026-04-17 12:03:15 +02:00
2022-12-11 16:58:50 +01:00
2025-05-05 08:19:11 +02:00
2026-04-15 09:23:21 +02:00
2026-02-26 17:34:42 +01:00
2026-02-16 09:14:03 +01:00
2026-04-13 12:06:27 +02:00
2023-11-20 21:12:13 +01:00
2025-01-14 07:46:40 +01:00
2024-03-16 08:35:18 +08:00
2025-01-14 07:46:40 +01:00
2025-09-22 08:48:48 +02:00
2025-07-19 08:17:30 +02:00
2024-04-10 14:41:16 +02:00
2023-08-10 14:26:40 +02:00
2026-04-17 12:03:05 +02:00
2025-04-14 10:52:41 +02:00
2025-12-15 20:29:49 +01:00
2026-03-30 15:10:17 +02:00
2026-04-03 12:47:11 +02:00
2023-10-29 14:48:11 +01:00
2024-08-20 11:57:47 +02:00
2026-01-26 09:12:59 +01:00
2023-12-12 16:54:50 +01:00
2026-01-09 08:48:56 +01:00
2026-03-10 09:30:31 +01:00
2026-04-01 08:35:32 +02:00
2023-08-10 14:26:40 +02:00
2024-04-10 14:41:16 +02:00
2025-05-12 14:20:32 +02:00
2023-10-29 14:48:11 +01:00
2025-01-14 12:24:00 +01:00
2023-12-25 07:12:54 +01:00