Files
Nim/tests/stdlib/tjsonutils.nim
Jake Leahy 81325d0745 Add checks to fromJson when trying to convert to an array (#26109)
Issue popped up when using `fromJson` into an array but the JSON passed
is an object

```nim
import std/[jsonutils, json]

let data = parseJson """
{"key": "value"}
"""
var foo: seq[int]
foo.fromJson(data)
echo foo #> @[0]
```
Basically the `setLen` would set the size to be equal to the number of
keys, but `getElems` just returns an empty array if the JSON isn't an
array which lead to it just creating zero'd items in the seq without
letting the user know.

Felt adding the checks was better than just skipping the `setLen` since
it lets the user know that there is a problem with the JSON
2026-08-19 08:24:25 +02:00

496 lines
18 KiB
Nim

discard """
matrix: "--mm:refc; --mm:orc"
targets: "c cpp js"
"""
import std/jsonutils
import std/json
from std/math import isNaN, signbit
from std/fenv import epsilon
from stdtest/testutils import whenRuntimeJs
import std/[assertions, objectdollar]
proc testRoundtrip[T](t: T, expected: string) =
# checks that `T => json => T2 => json2` is such that json2 = json
let j = t.toJson
doAssert $j == expected, "\n" & $j & "\n" & expected
doAssert j.jsonTo(T).toJson == j
var t2: T = default(T)
t2.fromJson(j)
doAssert t2.toJson == j
proc testRoundtripVal[T](t: T, expected: string) =
# similar to testRoundtrip, but also checks that the `T => json => T2` is such that `T2 == T`
# note that this isn't always possible, e.g. for pointer-like types.
let j = t.toJson
let j2 = $j
doAssert j2 == expected, j2
let j3 = j2.parseJson
let t2 = j3.jsonTo(T)
doAssert t2 == t
doAssert $t2.toJson == j2 # still needed, because -0.0 = 0.0 but their json representation differs
import tables, sets, algorithm, sequtils, options, strtabs
from strutils import contains
type Foo = ref object
id: int
proc `==`(a, b: Foo): bool =
a.id == b.id
type MyEnum = enum me0, me1 = "me1Alt", me2, me3, me4
proc `$`(a: MyEnum): string =
# putting this here pending https://github.com/nim-lang/Nim/issues/13747
if a == me2: "me2Modif"
else: system.`$`(a)
template fn() =
block: # toJson, jsonTo
type Foo = distinct float
testRoundtrip('x', """120""")
when not defined(js):
testRoundtrip(cast[pointer](12345)): """12345"""
when nimvm:
discard
# bugs:
# Error: unhandled exception: 'intVal' is not accessible using discriminant 'kind' of type 'TNode' [
# Error: VM does not support 'cast' from tyNil to tyPointer
else:
testRoundtrip(pointer(nil)): """0"""
testRoundtrip(cast[pointer](nil)): """0"""
# refs bug #9423
testRoundtrip(Foo(1.5)): """1.5"""
block: # OrderedTable
testRoundtrip({"z": "Z", "y": "Y"}.toOrderedTable): """{"z":"Z","y":"Y"}"""
doAssert toJson({"z": 10, "": 11}.newTable).`$`.contains """"":11""" # allows hash to change
testRoundtrip({"z".cstring: 1, "".cstring: 2}.toOrderedTable): """{"z":1,"":2}"""
testRoundtrip({"z": (f1: 'f'), }.toTable): """{"z":{"f1":102}}"""
block: # StringTable
testRoundtrip({"name": "John", "city": "Monaco"}.newStringTable): """{"mode":"modeCaseSensitive","table":{"city":"Monaco","name":"John"}}"""
block: # complex example
let t = {"z": "Z", "y": "Y"}.newStringTable
type A = ref object
a1: string
let a = (1.1, "fo", 'x', @[10,11], [true, false], [t,newStringTable()], [0'i8,3'i8], -4'i16, (foo: 0.5'f32, bar: A(a1: "abc"), bar2: A.default, cstring1: "foo", cstring2: "", cstring3: cstring(nil)))
testRoundtrip(a):
"""[1.1,"fo",120,[10,11],[true,false],[{"mode":"modeCaseSensitive","table":{"y":"Y","z":"Z"}},{"mode":"modeCaseSensitive","table":{}}],[0,3],-4,{"foo":0.5,"bar":{"a1":"abc"},"bar2":null,"cstring1":"foo","cstring2":"","cstring3":null}]"""
block:
# edge case when user defined `==` doesn't handle `nil` well, e.g.:
# https://github.com/nim-lang/nimble/blob/63695f490728e3935692c29f3d71944d83bb1e83/src/nimblepkg/version.nim#L105
testRoundtrip(@[Foo(id: 10), nil]): """[{"id":10},null]"""
block: # enum
type Foo = enum f1, f2, f3, f4, f5
type Bar = enum b1, b2, b3, b4
let a = [f2: b2, f3: b3, f4: b4]
doAssert b2.ord == 1 # explains the `1`
testRoundtrip(a): """[1,2,3]"""
block: # JsonNode
let a = ((1, 2.5, "abc").toJson, (3, 4.5, "foo"))
testRoundtripVal(a): """[[1,2.5,"abc"],[3,4.5,"foo"]]"""
block:
template toInt(a): untyped = cast[int](a)
let a = 3.toJson
let b = (a, a)
let c1 = b.toJson
doAssert c1[0].toInt == a.toInt
doAssert c1[1].toInt == a.toInt
let c2 = b.toJson(ToJsonOptions(jsonNodeMode: joptJsonNodeAsCopy))
doAssert c2[0].toInt != a.toInt
doAssert c2[1].toInt != c2[0].toInt
doAssert c2[1] == c2[0]
let c3 = b.toJson(ToJsonOptions(jsonNodeMode: joptJsonNodeAsObject))
doAssert $c3 == """[{"isUnquoted":false,"kind":2,"num":3},{"isUnquoted":false,"kind":2,"num":3}]"""
block: # ToJsonOptions
let a = (me1, me2)
doAssert $a.toJson() == "[1,2]"
doAssert $a.toJson(ToJsonOptions(enumMode: joptEnumSymbol)) == """["me1","me2"]"""
doAssert $a.toJson(ToJsonOptions(enumMode: joptEnumString)) == """["me1Alt","me2Modif"]"""
block: # set
type Foo = enum f1, f2, f3, f4, f5
type Goo = enum g1 = 10, g2 = 15, g3 = 17, g4
let a = ({f1, f3}, {1'u8, 7'u8}, {'0'..'9'}, {123'u16, 456, 789, 1121, 1122, 1542}, {g2, g3})
testRoundtrip(a): """[[0,2],[1,7],[48,49,50,51,52,53,54,55,56,57],[123,456,789,1121,1122,1542],[15,17]]"""
block: # bug #17383
block:
let a = (int32.high, uint32.high)
testRoundtrip(a): "[2147483647,4294967295]"
when int.sizeof > 4:
block:
let a = (int64.high, uint64.high)
testRoundtrip(a): "[9223372036854775807,18446744073709551615]"
block:
let a = (int.high, uint.high)
when int.sizeof == 4:
testRoundtrip(a): "[2147483647,4294967295]"
else:
testRoundtrip(a): "[9223372036854775807,18446744073709551615]"
block: # bug #18007
testRoundtrip((NaN, Inf, -Inf, 0.0, -0.0, 1.0)): """["nan","inf","-inf",0.0,-0.0,1.0]"""
testRoundtrip((float32(NaN), Inf, -Inf, 0.0, -0.0, 1.0)): """["nan","inf","-inf",0.0,-0.0,1.0]"""
testRoundtripVal((Inf, -Inf, 0.0, -0.0, 1.0)): """["inf","-inf",0.0,-0.0,1.0]"""
doAssert ($NaN.toJson).parseJson.jsonTo(float).isNaN
block: # bug #18009; unfixable unless we change parseJson (which would have overhead),
# but at least we can guarantee that the distinction between 0.0 and -0.0 is preserved.
let a = (0, 0.0, -0.0, 0.5, 1, 1.0)
testRoundtripVal(a): "[0,0.0,-0.0,0.5,1,1.0]"
let a2 = $($a.toJson).parseJson
whenRuntimeJs:
doAssert a2 == "[0,0,-0.0,0.5,1,1]"
do:
doAssert a2 == "[0,0.0,-0.0,0.5,1,1.0]"
let b = a2.parseJson.jsonTo(type(a))
doAssert not b[1].signbit
doAssert b[2].signbit
doAssert not b[3].signbit
block: # bug #15397, bug #13196
let a = 0.1
let x = 0.12345678901234567890123456789
let b = (a + 0.2, 0.3, x)
testRoundtripVal(b): "[0.30000000000000004,0.3,0.12345678901234568]"
testRoundtripVal(0.12345678901234567890123456789): "0.12345678901234568"
testRoundtripVal(epsilon(float64)): "2.220446049250313e-16"
testRoundtripVal(1.0 + epsilon(float64)): "1.0000000000000002"
block: # case object
type Foo = object
x0: float
case t1: bool
of true: z1: int8
of false: z2: uint16
x1: string
testRoundtrip(Foo(t1: true, z1: 5, x1: "bar")): """{"x0":0.0,"t1":true,"z1":5,"x1":"bar"}"""
testRoundtrip(Foo(x0: 1.5, t1: false, z2: 6)): """{"x0":1.5,"t1":false,"z2":6,"x1":""}"""
type PFoo = ref Foo
testRoundtrip(PFoo(x0: 1.5, t1: false, z2: 6)): """{"x0":1.5,"t1":false,"z2":6,"x1":""}"""
block: # ref case object
type Foo = ref object
x0: float
case t1: bool
of true: z1: int8
of false: z2: uint16
x1: string
testRoundtrip(Foo(t1: true, z1: 5, x1: "bar")): """{"x0":0.0,"t1":true,"z1":5,"x1":"bar"}"""
testRoundtrip(Foo(x0: 1.5, t1: false, z2: 6)): """{"x0":1.5,"t1":false,"z2":6,"x1":""}"""
block: # generic case object
type Foo[T] = ref object
x0: float
case t1: bool
of true: z1: int8
of false: z2: uint16
x1: string
testRoundtrip(Foo[float](t1: true, z1: 5, x1: "bar")): """{"x0":0.0,"t1":true,"z1":5,"x1":"bar"}"""
testRoundtrip(Foo[int](x0: 1.5, t1: false, z2: 6)): """{"x0":1.5,"t1":false,"z2":6,"x1":""}"""
# sanity check: nesting inside a tuple
testRoundtrip((Foo[int](x0: 1.5, t1: false, z2: 6), "foo")): """[{"x0":1.5,"t1":false,"z2":6,"x1":""},"foo"]"""
block: # generic case object using generic type
type Foo[T] = ref object
x0: float
case t1: bool
of true: z1: int8
of false: z2: uint16
x1: string
x2: T
testRoundtrip(Foo[float](t1: true, z1: 5, x1: "bar", x2: 2.5)): """{"x0":0.0,"t1":true,"z1":5,"x1":"bar","x2":2.5}"""
testRoundtrip(Foo[int](x0: 1.5, t1: false, z2: 6, x2: 2)): """{"x0":1.5,"t1":false,"z2":6,"x1":"","x2":2}"""
# sanity check: nesting inside a tuple
testRoundtrip((Foo[int](x0: 1.5, t1: false, z2: 6, x2: 2), "foo")): """[{"x0":1.5,"t1":false,"z2":6,"x1":"","x2":2},"foo"]"""
block: # case object: 2 discriminants, `when` branch, range discriminant
type Foo[T] = object
case t1: bool
of true:
z1: int8
of false:
z2: uint16
when T is float:
case t2: range[0..3]
of 0: z3: int8
of 2,3: z4: uint16
else: discard
testRoundtrip(Foo[float](t1: true, z1: 5, t2: 3, z4: 12)): """{"t1":true,"z1":5,"t2":3,"z4":12}"""
testRoundtrip(Foo[int](t1: false, z2: 7)): """{"t1":false,"z2":7}"""
# pending https://github.com/nim-lang/Nim/issues/14698, test with `type Foo[T] = ref object`
block: # bug: pass opt params in fromJson
type Foo = object
a: int
b: string
c: float
type Bar = object
foo: Foo
boo: string
var f: seq[Foo]
try:
fromJson(f, parseJson """[{"b": "bbb"}]""")
doAssert false
except ValueError:
doAssert true
fromJson(f, parseJson """[{"b": "bbb"}]""", Joptions(allowExtraKeys: true, allowMissingKeys: true))
doAssert f == @[Foo(a: 0, b: "bbb", c: 0.0)]
var b: Bar
fromJson(b, parseJson """{"foo": {"b": "bbb"}}""", Joptions(allowExtraKeys: true, allowMissingKeys: true))
doAssert b == Bar(foo: Foo(a: 0, b: "bbb", c: 0.0))
block: # jsonTo with `opt`
let b2 = """{"foo": {"b": "bbb"}}""".parseJson.jsonTo(Bar, Joptions(allowExtraKeys: true, allowMissingKeys: true))
doAssert b2 == Bar(foo: Foo(a: 0, b: "bbb", c: 0.0))
block testHashSet:
testRoundtrip(HashSet[string]()): "[]"
testRoundtrip([""].toHashSet): """[""]"""
testRoundtrip(["one"].toHashSet): """["one"]"""
var s: HashSet[string]
fromJson(s, parseJson("""["one","two"]"""))
doAssert s == ["one", "two"].toHashSet
let jsonNode = toJson(s)
doAssert jsonNode.elems.mapIt(it.str).sorted == @["one", "two"]
block testOrderedSet:
testRoundtrip(["one", "two", "three"].toOrderedSet):
"""["one","two","three"]"""
block testOption:
testRoundtrip(some("test")): "\"test\""
testRoundtrip(none[string]()): "null"
testRoundtrip(some(42)): "42"
testRoundtrip(none[int]()): "null"
block testStrtabs:
testRoundtrip(newStringTable(modeStyleInsensitive)):
"""{"mode":"modeStyleInsensitive","table":{}}"""
testRoundtrip(
newStringTable("name", "John", "surname", "Doe", modeCaseSensitive)):
"""{"mode":"modeCaseSensitive","table":{"name":"John","surname":"Doe"}}"""
block testJoptions:
type
AboutLifeUniverseAndEverythingElse = object
question: string
answer: int
block testExceptionOnExtraKeys:
var guide: AboutLifeUniverseAndEverythingElse
let json = parseJson(
"""{"question":"6*9=?","answer":42,"author":"Douglas Adams"}""")
doAssertRaises ValueError, fromJson(guide, json)
doAssertRaises ValueError,
fromJson(guide, json, Joptions(allowMissingKeys: true))
type
A = object
a1,a2,a3: int
var a: A
let j = parseJson("""{"a3": 1, "a4": 2}""")
doAssertRaises ValueError,
fromJson(a, j, Joptions(allowMissingKeys: true))
block testExceptionOnMissingKeys:
var guide: AboutLifeUniverseAndEverythingElse
let json = parseJson("""{"answer":42}""")
doAssertRaises ValueError, fromJson(guide, json)
doAssertRaises ValueError,
fromJson(guide, json, Joptions(allowExtraKeys: true))
block testAllowExtraKeys:
var guide: AboutLifeUniverseAndEverythingElse
let json = parseJson(
"""{"question":"6*9=?","answer":42,"author":"Douglas Adams"}""")
fromJson(guide, json, Joptions(allowExtraKeys: true))
doAssert guide == AboutLifeUniverseAndEverythingElse(
question: "6*9=?", answer: 42)
block refObject: #bug 17986
type A = ref object
case is_a: bool
of true:
a: int
else:
b: int
var a = A()
fromJson(a, """{"is_a": true, "a":1, "extra_key": 1}""".parseJson, Joptions(allowExtraKeys: true))
doAssert $a[] == "(is_a: true, a: 1)"
block testAllowMissingKeys:
var guide = AboutLifeUniverseAndEverythingElse(
question: "6*9=?", answer: 54)
let json = parseJson("""{"answer":42}""")
fromJson(guide, json, Joptions(allowMissingKeys: true))
doAssert guide == AboutLifeUniverseAndEverythingElse(
question: "6*9=?", answer: 42)
block testAllowExtraAndMissingKeys:
var guide = AboutLifeUniverseAndEverythingElse(
question: "6*9=?", answer: 54)
let json = parseJson(
"""{"answer":42,"author":"Douglas Adams"}""")
fromJson(guide, json, Joptions(
allowExtraKeys: true, allowMissingKeys: true))
doAssert guide == AboutLifeUniverseAndEverythingElse(
question: "6*9=?", answer: 42)
type
Foo = object
a: array[2, string]
case b: bool
of false: f: float
of true: t: tuple[i: int, s: string]
case c: range[0 .. 2]
of 0: c0: int
of 1: c1: float
of 2: c2: string
block testExceptionOnMissingDiscriminantKey:
var foo: Foo
let json = parseJson("""{"a":["one","two"]}""")
doAssertRaises ValueError, fromJson(foo, json)
block testDoNotResetMissingFieldsWhenHaveDiscriminantKey:
var foo = Foo(a: ["one", "two"], b: true, t: (i: 42, s: "s"),
c: 0, c0: 1)
let json = parseJson("""{"b":true,"c":2}""")
fromJson(foo, json, Joptions(allowMissingKeys: true))
doAssert foo.a == ["one", "two"]
doAssert foo.b
doAssert foo.t == (i: 42, s: "s")
doAssert foo.c == 2
doAssert foo.c2 == ""
block testAllowMissingDiscriminantKeys:
var foo: Foo
let json = parseJson("""{"a":["one","two"],"c":1,"c1":3.14159}""")
fromJson(foo, json, Joptions(allowMissingKeys: true))
doAssert foo.a == ["one", "two"]
doAssert not foo.b
doAssert foo.f == 0.0
doAssert foo.c == 1
doAssert foo.c1 == 3.14159
block testExceptionOnWrongDiscirminatBranchInJson:
var foo = Foo(b: false, f: 3.14159, c: 0, c0: 42)
let json = parseJson("""{"c2": "hello"}""")
doAssertRaises ValueError,
fromJson(foo, json, Joptions(allowMissingKeys: true))
# Test that the original fields are not reset.
doAssert not foo.b
doAssert foo.f == 3.14159
doAssert foo.c == 0
doAssert foo.c0 == 42
block testNoExceptionOnRightDiscriminantBranchInJson:
var foo = Foo(b: false, f: 0, c:1, c1: 0)
let json = parseJson("""{"f":2.71828,"c1": 3.14159}""")
fromJson(foo, json, Joptions(allowMissingKeys: true))
doAssert not foo.b
doAssert foo.f == 2.71828
doAssert foo.c == 1
doAssert foo.c1 == 3.14159
block testAllowExtraKeysInJsonOnWrongDisciriminatBranch:
var foo = Foo(b: false, f: 3.14159, c: 0, c0: 42)
let json = parseJson("""{"c2": "hello"}""")
fromJson(foo, json, Joptions(allowMissingKeys: true,
allowExtraKeys: true))
# Test that the original fields are not reset.
doAssert not foo.b
doAssert foo.f == 3.14159
doAssert foo.c == 0
doAssert foo.c0 == 42
block testInvalidTupleLength:
let json = parseJson("[0]")
# Should raise ValueError instead of index error
doAssertRaises(ValueError):
discard json.jsonTo((int, int))
type
InnerEnum = enum
A
B
C
InnerObject = object
x: string
y: InnerEnum
block testOptionsArePassedWhenDeserialising:
let json = parseJson("""{"x": "hello"}""")
let inner = json.jsonTo(Option[InnerObject], Joptions(allowMissingKeys: true))
doAssert inner.isSome()
doAssert inner.get().x == "hello"
doAssert inner.get().y == A
block testOptionsArePassedWhenSerialising:
let inner = some InnerObject(x: "hello", y: A)
let json = inner.toJson(ToJsonOptions(enumMode: joptEnumSymbol))
doAssert $json == """{"x":"hello","y":"A"}"""
block arrayTypeCheck:
let json = """{"key": "value"}""".parseJson()
var output: seq[int]
doAssertRaises(ValueError):
output.fromJson(json)
block: # bug #21638
type Something = object
doAssert "{}".parseJson.jsonTo(Something) == Something()
when false:
## TODO: Implement support for nested variant objects allowing the tests
## bellow to pass.
block testNestedVariantObjects:
type
Variant = object
case b: bool
of false:
case bf: bool
of false: bff: int
of true: bft: float
of true:
case bt: bool
of false: btf: string
of true: btt: char
testRoundtrip(Variant(b: false, bf: false, bff: 42)):
"""{"b": false, "bf": false, "bff": 42}"""
testRoundtrip(Variant(b: false, bf: true, bft: 3.14159)):
"""{"b": false, "bf": true, "bft": 3.14159}"""
testRoundtrip(Variant(b: true, bt: false, btf: "test")):
"""{"b": true, "bt": false, "btf": "test"}"""
testRoundtrip(Variant(b: true, bt: true, btt: 'c')):
"""{"b": true, "bt": true, "btt": "c"}"""
# TODO: Add additional tests with missing and extra JSON keys, both when
# allowed and forbidden analogous to the tests for the not nested
# variant objects.
static: fn()
fn()