mirrors/Odin
1
0
Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2026-09-02 18:23:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #7400 from kalsprite/union_slice_assert

Browse Source 
backend: only reuse a compound literal's storage for a variable of its type
This commit is contained in:
Jeroen van Rijn
2026-08-20 03:38:09 +02:00
committed by GitHub
parent 6695ca537d bc2649bacd
commit 00a03e72b5
2 changed files with 49 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/llvm_backend_stmt.cpp
View File

@@ -3390,7 +3390,10 @@ gb_internal void lb_build_stmt(lbProcedure *p, Ast *node) {
// NOTE(bill, 2023-02-17): lb_const_value might produce a stack local variable for the
// compound literal, so reusing that variable should minimize the stack wastage
lbAddr *comp_lit_addr = map_get(&p->module->exact_value_compound_literal_addr_map, rhs);
if (comp_lit_addr) {
// Only when the variable IS the literal. `x: U = []int{0}` declares a union and
// the literal is one of its variants, so reusing that storage would bind the
// variable to a bare `[]int` and never build the union at all
if (comp_lit_addr && are_types_identical(lb_addr_type(*comp_lit_addr), type_of_expr(vd->names[lval_index]))) {
if (Entity *e = entity_of_node(vd->names[lval_index])) {
lbValue val = comp_lit_addr->addr;
lb_add_entity(p->module, e, val);