mirrors/Odin
1
0
Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2026-01-04 20:17:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Correct procedure checking flag handling, and correct the (bodge) handle of unchecked procedure bodies

Browse Source
This commit is contained in:
gingerBill
2021-08-23 19:24:53 +01:00
parent fe2ad54f60
commit 382ca20916
6 changed files with 58 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/check_decl.cpp
View File

@@ -1249,7 +1249,7 @@ void check_proc_body(CheckerContext *ctx_, Token token, DeclInfo *decl, Type *ty
if (!(e->flags & EntityFlag_Using)) {
continue;
}
bool is_value = (e->flags & EntityFlag_Value) != 0 && !is_type_pointer(e->type);
bool is_value = (e->flags & EntityFlag_Value) != 0 && !is_type_pointer(e->type);
String name = e->token.string;
Type *t = base_type(type_deref(e->type));
if (t->kind == Type_Struct) {
@@ -1306,6 +1306,20 @@ void check_proc_body(CheckerContext *ctx_, Token token, DeclInfo *decl, Type *ty
check_stmt_list(ctx, bs->stmts, Stmt_CheckScopeDecls);
for_array(i, bs->stmts) {
Ast *stmt = bs->stmts[i];
if (stmt->kind == Ast_ValueDecl) {
ast_node(vd, ValueDecl, stmt);
for_array(j, vd->names) {
Ast *name = vd->names[j];
if (!is_blank_ident(name)) {
GB_ASSERT(name->kind == Ast_Ident);
GB_ASSERT(name->Ident.entity != nullptr);
}
}
}
}
if (type->Proc.result_count > 0) {
if (!check_is_terminating(body, str_lit(""))) {
if (token.kind == Token_Ident) {