mirrors/Odin
1
0
Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2026-08-14 09:44:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve error handling on set in set comparisons to suggest using <= instead

Browse Source
This commit is contained in:
gingerBill
2026-08-03 15:01:51 +01:00
parent 23b45391d2
commit 39e5d78aba
1 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/check_expr.cpp
View File

@@ -1311,9 +1311,13 @@ gb_internal void check_assignment(CheckerContext *c, Operand *operand, Type *typ
if (context_name == "procedure argument") {
if (is_type_slice(src) && are_types_identical(src->Slice.elem, dst)) {
gbString a = expr_to_string(operand->expr);
error_line("\tSuggestion: Did you mean to pass the slice into the variadic parameter with ..%s?\n\n", a);
error_line("\tSuggestion: Did you mean to pass the slice into the variadic parameter with ..%s?\n", a);
gb_string_free(a);
}
} else if (context_name == "bit_set 'in'") {
if (is_type_bit_set(operand->type)) {
error_line("\tSuggestion: Prefer <= if you want a superset\n");
}
}
if (src->kind == dst->kind && src->kind == Type_Proc) {
Type *x = src;
@@ -4425,7 +4429,12 @@ gb_internal void check_binary_expr(CheckerContext *c, Operand *x, Ast *node, Typ
if (is_type_bit_set(rhs_type)) {
Type *elem = base_type(rhs_type)->BitSet.elem;
check_expr_with_type_hint(c, x, be->left, elem);
Type *type_hint = elem;
Ast *left = unparen_expr(be->left);
if (left != nullptr && left->kind == Ast_CompoundLit) {
type_hint = rhs_type;
}
check_expr_with_type_hint(c, x, left, type_hint);
} else if (is_type_map(rhs_type)) {
Type *key = base_type(rhs_type)->Map.key;
check_expr_with_type_hint(c, x, be->left, key);