From 915a9589cc9ec9a04a7f5a6155d150d171df0400 Mon Sep 17 00:00:00 2001 From: victhor Date: Thu, 16 Apr 2026 08:56:00 +0200 Subject: [PATCH 1/2] Removed #by_ptr from args that are valid as nil The docs say nil is not valid for the rest of the functions that still have #by_ptr --- vendor/sdl3/mixer/sdl3_mixer.odin | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/vendor/sdl3/mixer/sdl3_mixer.odin b/vendor/sdl3/mixer/sdl3_mixer.odin index 36e5ecd1e..356eb87f8 100644 --- a/vendor/sdl3/mixer/sdl3_mixer.odin +++ b/vendor/sdl3/mixer/sdl3_mixer.odin @@ -76,8 +76,8 @@ foreign lib { Quit :: proc() --- GetNumAudioDecoders :: proc() -> c.int --- GetAudioDecoder :: proc(index: c.int) -> cstring --- - CreateMixerDevice :: proc(devid: SDL.AudioDeviceID, #by_ptr spec: SDL.AudioSpec) -> ^Mixer --- - CreateMixer :: proc(#by_ptr spec: SDL.AudioSpec) -> ^Mixer --- + CreateMixerDevice :: proc(devid: SDL.AudioDeviceID, spec: ^SDL.AudioSpec) -> ^Mixer --- + CreateMixer :: proc(spec: ^SDL.AudioSpec) -> ^Mixer --- DestroyMixer :: proc(mixer: ^Mixer) --- GetMixerProperties :: proc(mixer: ^Mixer) -> SDL.PropertiesID --- GetMixerFormat :: proc(mixer: ^Mixer, spec: ^SDL.AudioSpec) -> c.bool --- @@ -145,8 +145,8 @@ foreign lib { SetTrackFrequencyRatio :: proc(track: ^Track, ratio: c.float) -> c.bool --- GetTrackFrequencyRatio :: proc(track: ^Track) -> c.float --- SetTrackOutputChannelMap :: proc(track: ^Track, chmap: [^]c.int, count: c.int) -> c.bool --- - SetTrackStereo :: proc(track: ^Track, #by_ptr gains: StereoGains) -> c.bool --- - SetTrack3DPosition :: proc(track: ^Track, #by_ptr position: Point3D) -> c.bool --- + SetTrackStereo :: proc(track: ^Track, gains: ^StereoGains) -> c.bool --- + SetTrack3DPosition :: proc(track: ^Track, position: ^Point3D) -> c.bool --- GetTrack3DPosition :: proc(track: ^Track, position: ^Point3D) -> c.bool --- CreateGroup :: proc(mixer: ^Mixer) -> ^Group --- DestroyGroup :: proc(group: ^Group) --- From c9c42f986cecdde8cc8be9f80b7d205c37068ac4 Mon Sep 17 00:00:00 2001 From: victhor Date: Thu, 16 Apr 2026 11:19:45 +0200 Subject: [PATCH 2/2] Use Maybe(^T) --- vendor/sdl3/mixer/sdl3_mixer.odin | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/vendor/sdl3/mixer/sdl3_mixer.odin b/vendor/sdl3/mixer/sdl3_mixer.odin index 356eb87f8..276f94c8e 100644 --- a/vendor/sdl3/mixer/sdl3_mixer.odin +++ b/vendor/sdl3/mixer/sdl3_mixer.odin @@ -76,8 +76,8 @@ foreign lib { Quit :: proc() --- GetNumAudioDecoders :: proc() -> c.int --- GetAudioDecoder :: proc(index: c.int) -> cstring --- - CreateMixerDevice :: proc(devid: SDL.AudioDeviceID, spec: ^SDL.AudioSpec) -> ^Mixer --- - CreateMixer :: proc(spec: ^SDL.AudioSpec) -> ^Mixer --- + CreateMixerDevice :: proc(devid: SDL.AudioDeviceID, spec: Maybe(^SDL.AudioSpec)) -> ^Mixer --- + CreateMixer :: proc(spec: Maybe(^SDL.AudioSpec)) -> ^Mixer --- DestroyMixer :: proc(mixer: ^Mixer) --- GetMixerProperties :: proc(mixer: ^Mixer) -> SDL.PropertiesID --- GetMixerFormat :: proc(mixer: ^Mixer, spec: ^SDL.AudioSpec) -> c.bool --- @@ -145,8 +145,8 @@ foreign lib { SetTrackFrequencyRatio :: proc(track: ^Track, ratio: c.float) -> c.bool --- GetTrackFrequencyRatio :: proc(track: ^Track) -> c.float --- SetTrackOutputChannelMap :: proc(track: ^Track, chmap: [^]c.int, count: c.int) -> c.bool --- - SetTrackStereo :: proc(track: ^Track, gains: ^StereoGains) -> c.bool --- - SetTrack3DPosition :: proc(track: ^Track, position: ^Point3D) -> c.bool --- + SetTrackStereo :: proc(track: ^Track, gains: Maybe(^StereoGains)) -> c.bool --- + SetTrack3DPosition :: proc(track: ^Track, position: Maybe(^Point3D)) -> c.bool --- GetTrack3DPosition :: proc(track: ^Track, position: ^Point3D) -> c.bool --- CreateGroup :: proc(mixer: ^Mixer) -> ^Group --- DestroyGroup :: proc(group: ^Group) ---