mirrors/Odin
1
0
Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2025-12-30 09:54:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rename -vet-identical-cast to -vet-cast; with minor code clean up

Browse Source
This commit is contained in:
gingerBill
2024-06-29 11:44:45 +01:00
parent 4be0fc05bb
commit 704530497b
3 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/check_expr.cpp
View File

@@ -3382,18 +3382,18 @@ gb_internal void check_cast(CheckerContext *c, Operand *x, Type *type, bool forb
add_package_dependency(c, "runtime", "gnu_f2h_ieee", REQUIRE);
}
}
if (forbid_identical && check_vet_flags(c) & VetFlag_IdenticalCast) {
// If we check polymorphic procedures, we risk erring on
// identical casts that cannot be foreseen or otherwise
// forbidden, so just skip them.
if (forbid_identical && check_vet_flags(c) & VetFlag_Cast &&
(c->curr_proc_sig == nullptr || !is_type_polymorphic(c->curr_proc_sig))) {
Type *src_exact = x->type;
Type *dst_exact = type;
if (src_exact != nullptr &&
dst_exact != nullptr &&
// If we check polymorphic procedures, we risk erring on
// identical casts that cannot be foreseen or otherwise
// forbidden, so just skip them.
(c->curr_proc_sig == nullptr || !is_type_polymorphic(c->curr_proc_sig)) &&
src_exact == dst_exact)
{
dst_exact != nullptr &&
are_types_identical(src_exact, dst_exact)
) {
gbString oper_str = expr_to_string(x->expr);
gbString to_type = type_to_string(dst_exact);
error(x->expr, "Unneeded cast of `%s` to identical type `%s`", oper_str, to_type);