mirrors/Odin
1
0
Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2026-06-05 18:24:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add a recursion depth limit for #3987 with a consideration to use a switch statement or refactor the code to not use a large if-else chain

Browse Source
This commit is contained in:
gingerBill
2024-08-24 12:59:17 +01:00
parent 683dde1fa0
commit a4cc207022
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/parser.cpp
View File

@@ -4532,6 +4532,12 @@ gb_internal Ast *parse_if_stmt(AstFile *f) {
return ast_bad_stmt(f, f->curr_token, f->curr_token);
}
if (f->recursion_depth_else_if > 256) {
syntax_error(f->curr_token, "if-else chain recursion depth limit hit. Consider using a 'switch' statement instead or refactor the code to not require a large if-else chain");
f->recursion_depth_else_if = 0;
return ast_bad_stmt(f, f->curr_token, f->curr_token);
}
Token token = expect_token(f, Token_if);
Ast *init = nullptr;
Ast *cond = nullptr;
@@ -4577,7 +4583,9 @@ gb_internal Ast *parse_if_stmt(AstFile *f) {
Token else_token = expect_token(f, Token_else);
switch (f->curr_token.kind) {
case Token_if:
f->recursion_depth_else_if += 1;
else_stmt = parse_if_stmt(f);
f->recursion_depth_else_if -= 1;
break;
case Token_OpenBrace:
else_stmt = parse_block_stmt(f, false);