diff --git a/core/fmt/fmt.odin b/core/fmt/fmt.odin index 1c32c3ce7..06cb6703f 100644 --- a/core/fmt/fmt.odin +++ b/core/fmt/fmt.odin @@ -1929,12 +1929,12 @@ fmt_value :: proc(fi: ^Info, v: any, verb: rune) { if fi.hash { // Printed as it is written io.write_byte(fi.writer, '\n') - for col in 0.. 0 { io.write_string(fi.writer, ", ") } + for col in 0.. 0 { io.write_string(fi.writer, ", ") } - offset := (col + row*info.elem_stride)*info.elem_size + offset := (row + col*info.elem_stride)*info.elem_size data := uintptr(v.data) + uintptr(offset) fmt_arg(fi, any{rawptr(data), info.elem.id}, verb) @@ -1943,12 +1943,12 @@ fmt_value :: proc(fi: ^Info, v: any, verb: rune) { } } else { // Printed in Row-Major layout to match text layout - for col in 0.. 0 { io.write_string(fi.writer, "; ") } - for row in 0.. 0 { io.write_string(fi.writer, ", ") } + for row in 0.. 0 { io.write_string(fi.writer, "; ") } + for col in 0.. 0 { io.write_string(fi.writer, ", ") } - offset := (col + row*info.elem_stride)*info.elem_size + offset := (row + col*info.elem_stride)*info.elem_size data := uintptr(v.data) + uintptr(offset) fmt_arg(fi, any{rawptr(data), info.elem.id}, verb) diff --git a/src/llvm_backend_const.cpp b/src/llvm_backend_const.cpp index 82b409573..5862a7add 100644 --- a/src/llvm_backend_const.cpp +++ b/src/llvm_backend_const.cpp @@ -1010,6 +1010,11 @@ lbValue lb_const_value(lbModule *m, Type *type, ExactValue value, bool allow_loc if (op != Token_RangeHalf) { hi += 1; } + GB_ASSERT(0 <= lo && lo <= max_count); + GB_ASSERT(0 <= hi && hi <= max_count); + GB_ASSERT(lo <= hi); + + TypeAndValue tav = fv->value->tav; LLVMValueRef val = lb_const_value(m, elem_type, tav.value, allow_local).value; for (i64 k = lo; k < hi; k++) { @@ -1021,6 +1026,7 @@ lbValue lb_const_value(lbModule *m, Type *type, ExactValue value, bool allow_loc TypeAndValue index_tav = fv->field->tav; GB_ASSERT(index_tav.mode == Addressing_Constant); i64 index = exact_value_to_i64(index_tav.value); + GB_ASSERT(index < max_count); TypeAndValue tav = fv->value->tav; LLVMValueRef val = lb_const_value(m, elem_type, tav.value, allow_local).value; i64 offset = matrix_row_major_index_to_offset(type, index); diff --git a/src/types.cpp b/src/types.cpp index 652d383ee..e609815c6 100644 --- a/src/types.cpp +++ b/src/types.cpp @@ -1406,15 +1406,16 @@ i64 matrix_indices_to_offset(Type *t, i64 row_index, i64 column_index) { GB_ASSERT(0 <= row_index && row_index < t->Matrix.row_count); GB_ASSERT(0 <= column_index && column_index < t->Matrix.column_count); i64 stride_elems = matrix_type_stride_in_elems(t); - return stride_elems*column_index + row_index; + // NOTE(bill): Column-major layout internally + return row_index + stride_elems*column_index; } i64 matrix_row_major_index_to_offset(Type *t, i64 index) { t = base_type(t); GB_ASSERT(t->kind == Type_Matrix); - i64 column_index = index%t->Matrix.column_count; i64 row_index = index/t->Matrix.column_count; + i64 column_index = index%t->Matrix.column_count; return matrix_indices_to_offset(t, row_index, column_index); } i64 matrix_column_major_index_to_offset(Type *t, i64 index) {