From bd0cfe4a81400a4ab8dfbcc7b63177976a4ee0b5 Mon Sep 17 00:00:00 2001 From: Yawning Angel Date: Tue, 3 Feb 2026 16:13:52 +0900 Subject: [PATCH] core/crypto/_fiat: Minor p256 cleanups --- core/crypto/_fiat/field_p256r1/field.odin | 6 +++--- core/crypto/_fiat/field_scalarp256r1/field.odin | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/core/crypto/_fiat/field_p256r1/field.odin b/core/crypto/_fiat/field_p256r1/field.odin index 0ba0e327d..c2e2044aa 100644 --- a/core/crypto/_fiat/field_p256r1/field.odin +++ b/core/crypto/_fiat/field_p256r1/field.odin @@ -52,7 +52,7 @@ fe_from_bytes :: proc "contextless" ( fe_to_bytes :: proc "contextless" (out1: []byte, arg1: ^Montgomery_Domain_Field_Element) { ensure_contextless(len(out1) == 32, "p256r1: invalid fe output buffer") - tmp: Non_Montgomery_Domain_Field_Element + tmp: Non_Montgomery_Domain_Field_Element = --- fe_from_montgomery(&tmp, arg1) // Note: Likewise, output in big-endian. @@ -66,7 +66,7 @@ fe_to_bytes :: proc "contextless" (out1: []byte, arg1: ^Montgomery_Domain_Field_ @(require_results) fe_equal :: proc "contextless" (arg1, arg2: ^Montgomery_Domain_Field_Element) -> int { - tmp: Montgomery_Domain_Field_Element + tmp: Montgomery_Domain_Field_Element = --- fe_sub(&tmp, arg1, arg2) // This will only underflow iff arg1 == arg2, and we return the borrow, @@ -80,7 +80,7 @@ fe_equal :: proc "contextless" (arg1, arg2: ^Montgomery_Domain_Field_Element) -> @(require_results) fe_is_odd :: proc "contextless" (arg1: ^Montgomery_Domain_Field_Element) -> int { - tmp: Non_Montgomery_Domain_Field_Element + tmp: Non_Montgomery_Domain_Field_Element = --- defer mem.zero_explicit(&tmp, size_of(tmp)) fe_from_montgomery(&tmp, arg1) diff --git a/core/crypto/_fiat/field_scalarp256r1/field.odin b/core/crypto/_fiat/field_scalarp256r1/field.odin index 73c01fb46..0dfedb442 100644 --- a/core/crypto/_fiat/field_scalarp256r1/field.odin +++ b/core/crypto/_fiat/field_scalarp256r1/field.odin @@ -119,7 +119,7 @@ fe_unchecked_set :: proc "contextless" (out1: ^Montgomery_Domain_Field_Element, fe_to_bytes :: proc "contextless" (out1: []byte, arg1: ^Montgomery_Domain_Field_Element) { ensure_contextless(len(out1) == 32, "p256r1: invalid scalar output buffer") - tmp: Non_Montgomery_Domain_Field_Element + tmp: Non_Montgomery_Domain_Field_Element = --- fe_from_montgomery(&tmp, arg1) // Note: Likewise, output in big-endian. @@ -132,7 +132,7 @@ fe_to_bytes :: proc "contextless" (out1: []byte, arg1: ^Montgomery_Domain_Field_ } fe_equal :: proc "contextless" (arg1, arg2: ^Montgomery_Domain_Field_Element) -> int { - tmp: Montgomery_Domain_Field_Element + tmp: Montgomery_Domain_Field_Element = --- fe_sub(&tmp, arg1, arg2) is_eq := subtle.u64_is_zero(fe_non_zero(&tmp)) @@ -143,7 +143,7 @@ fe_equal :: proc "contextless" (arg1, arg2: ^Montgomery_Domain_Field_Element) -> } fe_is_odd :: proc "contextless" (arg1: ^Montgomery_Domain_Field_Element) -> int { - tmp: Non_Montgomery_Domain_Field_Element + tmp: Non_Montgomery_Domain_Field_Element = --- defer mem.zero_explicit(&tmp, size_of(tmp)) fe_from_montgomery(&tmp, arg1)