mirrors/Odin
1
0
Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2026-02-13 23:03:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add warning for things like 1.0 / some_int

Browse Source
This commit is contained in:
gingerBill
2023-11-04 11:22:06 +00:00
parent e206d6ba35
commit ce5e7998ba
1 changed files with 24 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/check_expr.cpp
View File

@@ -3558,6 +3558,30 @@ gb_internal void check_binary_expr(CheckerContext *c, Operand *x, Ast *node, Typ
return;
}
switch (op.kind) {
case Token_Quo:
case Token_Mod:
case Token_ModMod:
case Token_QuoEq:
case Token_ModEq:
case Token_ModModEq:
if (is_type_integer(y->type) && !is_type_untyped(y->type) &&
is_type_float(x->type) && is_type_untyped(x->type)) {
char const *suggestion = "\tSuggestion: Try explicitly casting the constant value for clarity";
gbString t = type_to_string(y->type);
if (x->value.kind != ExactValue_Invalid) {
gbString s = exact_value_to_string(x->value);
warning(node, "Dividing an untyped float '%s' by '%s' will perform integer division\n%s", s, t, suggestion);
gb_string_free(s);
} else {
warning(node, "Dividing an untyped float by '%s' will perform integer division\n%s", t, suggestion);
}
gb_string_free(t);
}
break;
}
convert_to_typed(c, x, y->type);
if (x->mode == Addressing_Invalid) {
return;