mirrors/Odin
1
0
Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2026-05-25 13:18:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add suggestion for ~uint(0) if cast(uint)-1 is done

Browse Source
This commit is contained in:
gingerBill
2024-08-18 22:52:57 +01:00
parent 95c3b8a8de
commit d99a6ad003
1 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/check_expr.cpp
View File

@@ -2332,14 +2332,24 @@ gb_internal bool check_integer_exceed_suggestion(CheckerContext *c, Operand *o,
}
BigInt *bi = &o->value.value_integer;
if (is_type_unsigned(type)) {
BigInt one = big_int_make_u64(1);
BigInt max_size = big_int_make_u64(1);
BigInt bits = big_int_make_i64(bit_size);
big_int_shl_eq(&max_size, &bits);
big_int_sub_eq(&max_size, &one);
if (big_int_is_neg(bi)) {
error_line("\tA negative value cannot be represented by the unsigned integer type '%s'\n", b);
BigInt dst = {};
big_int_neg(&dst, bi);
if (big_int_cmp(&dst, &max_size) < 0) {
big_int_sub_eq(&dst, &one);
String dst_str = big_int_to_string(temporary_allocator(), &dst);
gbString t = type_to_string(type);
error_line("\tSuggestion: ~%s(%.*s)\n", t, LIT(dst_str));
gb_string_free(t);
}
} else {
BigInt one = big_int_make_u64(1);
BigInt max_size = big_int_make_u64(1);
BigInt bits = big_int_make_i64(bit_size);
big_int_shl_eq(&max_size, &bits);
big_int_sub_eq(&max_size, &one);
String max_size_str = big_int_to_string(temporary_allocator(), &max_size);
if (size_changed) {