mirrors/Odin
1
0
Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2026-05-27 06:08:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

make c vararg with any vs concrete type similar enough

Browse Source
This commit is contained in:
Laytan
2024-09-04 18:47:08 +02:00
parent b2c5998e78
commit dcf339517e
1 changed files with 24 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/check_decl.cpp
View File

@@ -768,6 +768,19 @@ gb_internal bool are_signatures_similar_enough(Type *a_, Type *b_) {
if (a->result_count != b->result_count) {
return false;
}
if (a->c_vararg != b->c_vararg) {
return false;
}
if (a->variadic != b->variadic) {
return false;
}
if (a->variadic && a->variadic_index != b->variadic_index) {
return false;
}
for (isize i = 0; i < a->param_count; i++) {
Type *x = core_type(a->params->Tuple.variables[i]->type);
Type *y = core_type(b->params->Tuple.variables[i]->type);
@@ -779,6 +792,17 @@ gb_internal bool are_signatures_similar_enough(Type *a_, Type *b_) {
y = core_type(y->BitSet.underlying);
}
// Allow a `#c_vararg args: ..any` with `#c_vararg args: ..foo`.
if (a->variadic && i == a->variadic_index) {
GB_ASSERT(x->kind == Type_Slice);
GB_ASSERT(y->kind == Type_Slice);
Type *x_elem = core_type(x->Slice.elem);
Type *y_elem = core_type(y->Slice.elem);
if (is_type_any(x_elem) || is_type_any(y_elem)) {
continue;
}
}
if (!signature_parameter_similar_enough(x, y)) {
return false;
}