mirrors/Odin
1
0
Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2026-01-01 10:52:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve error suggestion and propagation for x->y

Browse Source
This commit is contained in:
gingerBill
2024-03-23 16:57:35 +00:00
parent eb51cc6835
commit efb0933965
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/check_expr.cpp
View File

@@ -4900,10 +4900,18 @@ gb_internal Entity *check_selector(CheckerContext *c, Operand *operand, Ast *nod
Selection sel = {}; // NOTE(bill): Not used if it's an import name
if (!c->allow_arrow_right_selector_expr && se->token.kind == Token_ArrowRight) {
ERROR_BLOCK();
error(node, "Illegal use of -> selector shorthand outside of a call");
operand->mode = Addressing_Invalid;
operand->expr = node;
return nullptr;
gbString x = expr_to_string(se->expr);
gbString y = expr_to_string(se->selector);
error_line("\tSuggestion: Did you mean '%s.%s'?\n", x, y);
gb_string_free(y);
gb_string_free(x);
// TODO(bill): Should this terminate here or propagate onwards?
// operand->mode = Addressing_Invalid;
// operand->expr = node;
// return nullptr;
}
operand->expr = node;