12 Commits

Author SHA1 Message Date
Laytan Laats
e6bd79c882 Make sure we are listening before starting the client 2024-02-20 23:54:11 +01:00
Laytan Laats
9e417592e3 Add logs to flaky test 2024-02-20 23:45:15 +01:00
Laytan Laats
bdd6a86d73 Remove flaky test
It wasn't testing the right thing in the previous
iteration.
And in this iteration the behaviour is a timeout on Unix, and
nothing on Windows.
2024-02-20 23:15:18 +01:00
Laytan Laats
1ab3ec5731 Improve net tests
Watching the sporadic CI failures it seems to come from these tests a
lot of the time, this PR cleans up and simplifies (while testing the
same things):

1. Lots of tests were using threads without a need for it
2. Tests had hardcoded `time.sleep` calls which is never a good idea
3. An unclear abstraction was implemented without a real need
4. They weren't being ran on non-windows
5. The `client_connects_to_open_but_not_accepting_port` was not doing
   what you wanted to test for, the `tcp_server` proc was returning, and
   then `dial` was called, which meant that the server already closed
   and you got a refusal error. Now it correctly listens without
   accepting, which even results in a different error because the kernel
   buffer would have buffered the send
2024-02-20 23:06:18 +01:00
Jeroen van Rijn
761a079789 Fix net.split_url
Resolves issue #2924
2023-11-09 16:56:54 +01:00
Jeroen van Rijn
81fe93127d Make core:net test os.exit(1) on failure. 2023-09-30 22:47:49 +02:00
Jeroen van Rijn
aa5716d3f9 Allow any order of query strings in net.join_url tests. 2023-09-30 22:36:50 +02:00
Yoshihiro Tanaka
59e66ffe49 Add test for net.split_url 2023-05-14 12:15:20 +09:00
Yoshihiro Tanaka
418a0132d0 Join URL queries with & 2023-05-14 12:15:20 +09:00
Jeroen van Rijn
e254581a1b Apply #shared_nil to Network_Error 2023-03-04 10:39:20 +01:00
Jeroen van Rijn
5c05038af0 Finish cleaning up core_net. 2023-03-03 17:26:44 +01:00
Colin Davidson
28f7f57247 manually start merging core_net 2023-03-01 07:58:30 -08:00