mirrors/SDL
1
0
Fork 0
mirror of https://github.com/libsdl-org/SDL.git synced 2025-09-06 11:28:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

wayland: Cap the max key repeat elapsed time

Browse Source 
Cap the elapsed time to something sane in case the compositor sends a bad timestamp, which can result it in it looking like the key has been pressed for a *very* long time, bringing everything to a halt while it tries to enqueue all the repeat events.
This commit is contained in:
Frank Praznik
2025-05-21 12:18:36 -04:00
parent 20e8ac0075
commit 05f779f61e
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/video/wayland/SDL_waylandevents.c
View File

@@ -308,6 +308,15 @@ void Wayland_DisplayInitCursorShapeManager(SDL_VideoData *display)
static bool keyboard_repeat_handle(SDL_WaylandKeyboardRepeat *repeat_info, Uint64 elapsed) static bool keyboard_repeat_handle(SDL_WaylandKeyboardRepeat *repeat_info, Uint64 elapsed)
{ {
bool ret = false; bool ret = false;
/* Cap the elapsed time to something sane in case the compositor sends a bad timestamp,
* which can result it in it looking like the key has been pressed for a *very* long time,
* bringing everything to a halt while it tries to enqueue all the repeat events.
*
* 3 seconds seems reasonable.
*/
elapsed = SDL_min(elapsed, SDL_MS_TO_NS(3000));
while (elapsed >= repeat_info->next_repeat_ns) { while (elapsed >= repeat_info->next_repeat_ns) {
if (repeat_info->scancode != SDL_SCANCODE_UNKNOWN) { if (repeat_info->scancode != SDL_SCANCODE_UNKNOWN) {
const Uint64 timestamp = repeat_info->wl_press_time_ns + repeat_info->next_repeat_ns; const Uint64 timestamp = repeat_info->wl_press_time_ns + repeat_info->next_repeat_ns;