mirrors/SDL
1
0
Fork 0
mirror of https://github.com/libsdl-org/SDL.git synced 2025-09-28 14:08:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix device suitability checks in Vulkan GPU backend to always adhere to priority arrays

Browse Source
This commit is contained in:
Jaan Soulier
2025-08-26 21:33:57 -04:00
committed by Sam Lantinga
parent 26d6352500
commit 0bbdd86b86
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/gpu/vulkan/SDL_gpu_vulkan.c
View File

@@ -11274,14 +11274,20 @@ static Uint8 VULKAN_INTERNAL_IsDeviceSuitable(
renderer->vkGetPhysicalDeviceProperties( renderer->vkGetPhysicalDeviceProperties(
physicalDevice, physicalDevice,
&deviceProperties); &deviceProperties);
if (*deviceRank < devicePriority[deviceProperties.deviceType]) {
/* Apply a large bias on the devicePriority so that we always respect the order in the priority arrays.
* We also rank by e.g. VRAM which should have less influence than the device type.
*/
Uint64 devicePriorityValue = devicePriority[deviceProperties.deviceType] * 1000000;
if (*deviceRank < devicePriorityValue) {
/* This device outranks the best device we've found so far! /* This device outranks the best device we've found so far!
* This includes a dedicated GPU that has less features than an * This includes a dedicated GPU that has less features than an
* integrated GPU, because this is a freak case that is almost * integrated GPU, because this is a freak case that is almost
* never intentionally desired by the end user * never intentionally desired by the end user
*/ */
*deviceRank = devicePriority[deviceProperties.deviceType]; *deviceRank = devicePriorityValue;
} else if (*deviceRank > devicePriority[deviceProperties.deviceType]) { } else if (*deviceRank > devicePriorityValue) {
/* Device is outranked by a previous device, don't even try to /* Device is outranked by a previous device, don't even try to
* run a query and reset the rank to avoid overwrites * run a query and reset the rank to avoid overwrites
*/ */