From 1bf5a78b5310b51dfb457821b462d6e0c5ec570e Mon Sep 17 00:00:00 2001 From: Frank Praznik Date: Fri, 5 May 2023 14:04:15 -0400 Subject: [PATCH] wayland: Don't print an error when moving a hidden popup window Repositioning a hidden popup window is valid behavior, so don't print an error message in this case. --- src/video/wayland/SDL_waylandwindow.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/video/wayland/SDL_waylandwindow.c b/src/video/wayland/SDL_waylandwindow.c index 87b189daca..135feef18c 100644 --- a/src/video/wayland/SDL_waylandwindow.c +++ b/src/video/wayland/SDL_waylandwindow.c @@ -2147,8 +2147,9 @@ int Wayland_SetWindowPosition(_THIS, SDL_Window *window) SDL_WindowData *wind = window->driverdata; /* Only popup windows can be positioned relative to the parent. */ - if (wind->shell_surface_type == WAYLAND_SURFACE_XDG_POPUP && wind->shell_surface.xdg.roleobj.popup.popup) { - if (xdg_popup_get_version(wind->shell_surface.xdg.roleobj.popup.popup) < XDG_POPUP_REPOSITION_SINCE_VERSION) { + if (wind->shell_surface_type == WAYLAND_SURFACE_XDG_POPUP) { + if (wind->shell_surface.xdg.roleobj.popup.popup && + xdg_popup_get_version(wind->shell_surface.xdg.roleobj.popup.popup) < XDG_POPUP_REPOSITION_SINCE_VERSION) { return SDL_Unsupported(); }