mirrors/SDL
1
0
Fork 0
mirror of https://github.com/libsdl-org/SDL.git synced 2025-09-15 07:48:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Android: potential ANR during onKeyDown/Up

Browse Source 
SDLActivity may call onNativeKeyDown, while application is quitting
This commit is contained in:
Sylvain
2023-06-16 10:05:58 +02:00
committed by Sylvain Becker
parent e72935a445
commit 378e33bb2c
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/core/android/SDL_android.c
View File

@@ -1157,7 +1157,13 @@ JNIEXPORT void JNICALL SDL_JAVA_INTERFACE(onNativeKeyDown)(
JNIEnv *env, jclass jcls, JNIEnv *env, jclass jcls,
jint keycode) jint keycode)
{ {
Android_OnKeyDown(keycode); SDL_LockMutex(Android_ActivityMutex);
if (Android_Window) {
Android_OnKeyDown(keycode);
}
SDL_UnlockMutex(Android_ActivityMutex);
} }
/* Keyup */ /* Keyup */
@@ -1165,7 +1171,13 @@ JNIEXPORT void JNICALL SDL_JAVA_INTERFACE(onNativeKeyUp)(
JNIEnv *env, jclass jcls, JNIEnv *env, jclass jcls,
jint keycode) jint keycode)
{ {
Android_OnKeyUp(keycode); SDL_LockMutex(Android_ActivityMutex);
if (Android_Window) {
Android_OnKeyUp(keycode);
}
SDL_UnlockMutex(Android_ActivityMutex);
} }
/* Virtual keyboard return key might stop text input */ /* Virtual keyboard return key might stop text input */