mirrors/SDL
1
0
Fork 0
mirror of https://github.com/libsdl-org/SDL.git synced 2025-09-06 19:38:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix buffer overrun in ConvertAudio with different src/dst channel count

Browse Source 
- Source or destination format also has to not be F32 to trigger bug
This commit is contained in:
hspir404
2025-01-23 02:32:00 -08:00
committed by Ryan C. Gordon
parent 983cfe8b1c
commit 72a3eae0da
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/audio/SDL_audiocvt.c
View File

@@ -325,7 +325,7 @@ void ConvertAudio(int num_frames,
// Gain adjustment // Gain adjustment
if (gain != 1.0f) { if (gain != 1.0f) {
float *buf = (float *)(dstconvert ? scratch : dst); float *buf = (float *)((channelconvert || dstconvert) ? scratch : dst);
const int total_samples = num_frames * src_channels; const int total_samples = num_frames * src_channels;
if (src == buf) { if (src == buf) {
for (int i = 0; i < total_samples; i++) { for (int i = 0; i < total_samples; i++) {